From e1b0d7b60d6ff0ebf411ea0b332a1d9ad56f56bc Mon Sep 17 00:00:00 2001 From: Leviathes <73369223+Leviathes@users.noreply.github.com> Date: Mon, 11 Oct 2021 17:58:45 -0400 Subject: [PATCH 1/2] Grammar/Flow Just a few changes to make this section easier to comprehend. A few things were only technically wrong (using singulars instead of plurals or vice/versa). Changed the wording of some things to make the intent clearer. --- docs/user-guides/cmake-user.rst | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/docs/user-guides/cmake-user.rst b/docs/user-guides/cmake-user.rst index 0f859325b2..59dc6c2c13 100644 --- a/docs/user-guides/cmake-user.rst +++ b/docs/user-guides/cmake-user.rst @@ -5,19 +5,20 @@ CMake user ---------- This kind of developer can **read** CMake code that was written by more -experienced CMake developer. He understand some simple features like that -executable added by ``add_executable`` command and this command contains list -of sources files. But probably will not be able to tell why in some cases -``include_directories`` command called but ``target_include_directories`` in -other cases. The main target of modifications is C++ code. +experienced CMake developer. They understand some simple features such as +adding an executable with the ``add_executable`` command, and that this +command contains a list of source files associated with the executable. +They will probably have difficulty understanding why, in some cases, the +``include_directories`` command is called, but in others, ``target_include_directories`` +is called instead. The main target of modifications is C++ code. -Such developers can do: +Such developers can: -* Add more targets to project +* Add more targets to projects * Add more sources to targets -* Add C++ flags that does not break compatibility (e.g. warnings/optimization) +* Add C++ flags that don't break compatibility (e.g. warnings/optimization) -Such developers can't do: +Such developers can't: * Add more external dependencies to project * Adding flags that can break compatibility (e.g. ``-std=c++11`` or ``/MT``) From 4a921a0fa1f73a55c7925c7aaff8c733f30040e0 Mon Sep 17 00:00:00 2001 From: Leviathes <73369223+Leviathes@users.noreply.github.com> Date: Tue, 12 Oct 2021 21:09:25 -0400 Subject: [PATCH 2/2] Update cmake-user.rst --- docs/user-guides/cmake-user.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/user-guides/cmake-user.rst b/docs/user-guides/cmake-user.rst index 59dc6c2c13..e93ee33dd9 100644 --- a/docs/user-guides/cmake-user.rst +++ b/docs/user-guides/cmake-user.rst @@ -5,7 +5,7 @@ CMake user ---------- This kind of developer can **read** CMake code that was written by more -experienced CMake developer. They understand some simple features such as +experienced CMake developers. They understand some simple features such as adding an executable with the ``add_executable`` command, and that this command contains a list of source files associated with the executable. They will probably have difficulty understanding why, in some cases, the