Skip to content

Conversation

@MungoG
Copy link

@MungoG MungoG commented Nov 19, 2025

No description provided.

@MungoG MungoG linked an issue Nov 19, 2025 that may be closed by this pull request
@cppalliance-bot
Copy link

cppalliance-bot commented Nov 19, 2025

An automated preview of the documentation is available at https://54.buffers.prtest.cppalliance.org/index.html

If more commits are pushed to the pull request, the docs will rebuild at the same URL.

2025-11-21 18:27:11 UTC

@MungoG MungoG requested review from ashtum and vinniefalco November 19, 2025 13:33
@codecov
Copy link

codecov bot commented Nov 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.01%. Comparing base (a0d1585) to head (6c5ee63).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #54      +/-   ##
===========================================
+ Coverage    97.97%   98.01%   +0.04%     
===========================================
  Files           12       12              
  Lines          493      505      +12     
===========================================
+ Hits           483      495      +12     
  Misses          10       10              
Files with missing lines Coverage Δ
include/boost/buffers/slice.hpp 98.03% <100.00%> (+0.16%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0d1585...6c5ee63. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ashtum
Copy link
Collaborator

ashtum commented Nov 20, 2025

Does this buffer type has proper test cases for move and copy operations? It's odd that it has been passing the tests before this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

slice_of internal iterators get invalidated on move

3 participants