From 703befeb2341bf4442e68fd16f53170e3c2560d1 Mon Sep 17 00:00:00 2001 From: firewave Date: Mon, 19 Dec 2022 13:22:20 +0100 Subject: [PATCH 1/2] added missing `const` in casts --- lib/checkbufferoverrun.cpp | 2 +- lib/checkclass.cpp | 2 +- lib/checknullpointer.cpp | 2 +- lib/checkuninitvar.cpp | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/checkbufferoverrun.cpp b/lib/checkbufferoverrun.cpp index 66ab4884243..64a3b5a9c30 100644 --- a/lib/checkbufferoverrun.cpp +++ b/lib/checkbufferoverrun.cpp @@ -960,7 +960,7 @@ bool CheckBufferOverrun::analyseWholeProgram(const CTU::FileInfo *ctu, const std const std::map> callsMap = ctu->getCallsMap(); for (Check::FileInfo *fi1 : fileInfo) { - const MyFileInfo *fi = dynamic_cast(fi1); + const MyFileInfo *fi = dynamic_cast(fi1); if (!fi) continue; for (const CTU::FileInfo::UnsafeUsage &unsafeUsage : fi->unsafeArrayIndex) diff --git a/lib/checkclass.cpp b/lib/checkclass.cpp index b699a42c659..db036b91b7c 100644 --- a/lib/checkclass.cpp +++ b/lib/checkclass.cpp @@ -3199,7 +3199,7 @@ bool CheckClass::analyseWholeProgram(const CTU::FileInfo *ctu, const std::list all; for (Check::FileInfo *fi1 : fileInfo) { - const MyFileInfo *fi = dynamic_cast(fi1); + const MyFileInfo *fi = dynamic_cast(fi1); if (!fi) continue; for (const MyFileInfo::NameLoc &nameLoc : fi->classDefinitions) { diff --git a/lib/checknullpointer.cpp b/lib/checknullpointer.cpp index de51282e98c..959bf014d39 100644 --- a/lib/checknullpointer.cpp +++ b/lib/checknullpointer.cpp @@ -597,7 +597,7 @@ bool CheckNullPointer::analyseWholeProgram(const CTU::FileInfo *ctu, const std:: const std::map> callsMap = ctu->getCallsMap(); for (Check::FileInfo *fi1 : fileInfo) { - const MyFileInfo *fi = dynamic_cast(fi1); + const MyFileInfo *fi = dynamic_cast(fi1); if (!fi) continue; for (const CTU::FileInfo::UnsafeUsage &unsafeUsage : fi->unsafeUsage) { diff --git a/lib/checkuninitvar.cpp b/lib/checkuninitvar.cpp index 14c08e408b8..0d8e92e98b3 100644 --- a/lib/checkuninitvar.cpp +++ b/lib/checkuninitvar.cpp @@ -1703,7 +1703,7 @@ bool CheckUninitVar::analyseWholeProgram(const CTU::FileInfo *ctu, const std::li const std::map> callsMap = ctu->getCallsMap(); for (Check::FileInfo *fi1 : fileInfo) { - const MyFileInfo *fi = dynamic_cast(fi1); + const MyFileInfo *fi = dynamic_cast(fi1); if (!fi) continue; for (const CTU::FileInfo::UnsafeUsage &unsafeUsage : fi->unsafeUsage) { From 7e3cff623d22999ba38bf0ee4ccff664c1a8183a Mon Sep 17 00:00:00 2001 From: firewave Date: Mon, 19 Dec 2022 13:22:51 +0100 Subject: [PATCH 2/2] cast to `const` object --- gui/resultsview.cpp | 2 +- gui/statsdialog.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/gui/resultsview.cpp b/gui/resultsview.cpp index 20066aeb376..a0e0e0b61bf 100644 --- a/gui/resultsview.cpp +++ b/gui/resultsview.cpp @@ -373,7 +373,7 @@ void ResultsView::readErrorsXml(const QString &filename) void ResultsView::updateDetails(const QModelIndex &index) { - QStandardItemModel *model = qobject_cast(mUI->mTree->model()); + const QStandardItemModel *model = qobject_cast(mUI->mTree->model()); QStandardItem *item = model->itemFromIndex(index); if (!item) { diff --git a/gui/statsdialog.cpp b/gui/statsdialog.cpp index 91bc24bf9b8..16ec8cb141a 100644 --- a/gui/statsdialog.cpp +++ b/gui/statsdialog.cpp @@ -382,7 +382,7 @@ QChartView *StatsDialog::createChart(const QString &statsFile, const QString &to qreal maxY = 0; for (QAbstractSeries *s : chart->series()) { s->attachAxis(axisY); - if (QLineSeries *ls = dynamic_cast(s)) { + if (const QLineSeries *ls = dynamic_cast(s)) { for (QPointF p : ls->points()) { if (p.y() > maxY) maxY = p.y();