From 9a438268f4b67b269742c56d7b879f67fb230ad9 Mon Sep 17 00:00:00 2001 From: firewave Date: Sat, 9 Mar 2024 16:58:13 +0100 Subject: [PATCH 1/6] restored name of `CI-cygwin.yml` --- .github/workflows/{CI-cygwin.yml.deactivated => CI-cygwin.yml} | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename .github/workflows/{CI-cygwin.yml.deactivated => CI-cygwin.yml} (100%) diff --git a/.github/workflows/CI-cygwin.yml.deactivated b/.github/workflows/CI-cygwin.yml similarity index 100% rename from .github/workflows/CI-cygwin.yml.deactivated rename to .github/workflows/CI-cygwin.yml From be7cfe606459881b4c12530642a2b1c8b7fa0902 Mon Sep 17 00:00:00 2001 From: firewave Date: Sat, 9 Mar 2024 16:59:28 +0100 Subject: [PATCH 2/6] CI-cygwin.yml: disabled job --- .github/workflows/CI-cygwin.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/CI-cygwin.yml b/.github/workflows/CI-cygwin.yml index b9ea30470da..0c7c9baec9b 100644 --- a/.github/workflows/CI-cygwin.yml +++ b/.github/workflows/CI-cygwin.yml @@ -34,6 +34,7 @@ jobs: fail-fast: false runs-on: ${{ matrix.os }} + if: false # the hard-coded cygwin repository has changed so the setup step fails - TODO: re-enable steps: - uses: actions/checkout@v3 From 56335e2ce31e03837e2d26b9e0adb33ae442deb4 Mon Sep 17 00:00:00 2001 From: firewave Date: Sat, 9 Mar 2024 17:01:25 +0100 Subject: [PATCH 3/6] do not run the scheduled jobs on forks --- .github/workflows/iwyu.yml | 2 ++ .github/workflows/release-windows.yml | 1 + 2 files changed, 3 insertions(+) diff --git a/.github/workflows/iwyu.yml b/.github/workflows/iwyu.yml index a4c2c2a638f..4bcd3eceb58 100644 --- a/.github/workflows/iwyu.yml +++ b/.github/workflows/iwyu.yml @@ -18,6 +18,7 @@ jobs: image: ["opensuse/tumbleweed:latest"] # "fedora:latest" / "debian:unstable" / "archlinux:latest" runs-on: ubuntu-22.04 + if: ${{ github.repository_owner == 'danmar' }} container: image: ${{ matrix.image }} @@ -118,6 +119,7 @@ jobs: clang-include-cleaner: runs-on: ubuntu-22.04 + if: ${{ github.repository_owner == 'danmar' }} env: QT_VERSION: 5.15.2 diff --git a/.github/workflows/release-windows.yml b/.github/workflows/release-windows.yml index f10a67eaed2..2e1d9d7cabd 100644 --- a/.github/workflows/release-windows.yml +++ b/.github/workflows/release-windows.yml @@ -24,6 +24,7 @@ jobs: build: runs-on: windows-2022 + if: ${{ github.repository_owner == 'danmar' }} env: # see https://www.pcre.org/original/changelog.txt From e18528ea4ab3f06553b0b44ab6af41da8afe3a48 Mon Sep 17 00:00:00 2001 From: firewave Date: Sat, 9 Mar 2024 17:01:43 +0100 Subject: [PATCH 4/6] cifuzz.yml: do not run on forks --- .github/workflows/cifuzz.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/cifuzz.yml b/.github/workflows/cifuzz.yml index 19c40de61c9..38b1ab717a6 100644 --- a/.github/workflows/cifuzz.yml +++ b/.github/workflows/cifuzz.yml @@ -3,6 +3,7 @@ on: [pull_request] jobs: Fuzzing: runs-on: ubuntu-latest + if: ${{ github.repository_owner == 'danmar' }} steps: - name: Build Fuzzers id: build From 912709fc1115d5be752df6bbe6c2cec44a055ccb Mon Sep 17 00:00:00 2001 From: firewave Date: Sat, 9 Mar 2024 17:04:14 +0100 Subject: [PATCH 5/6] cifuzz.yml: added missing permissions --- .github/workflows/cifuzz.yml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.github/workflows/cifuzz.yml b/.github/workflows/cifuzz.yml index 38b1ab717a6..2d2f5f1f237 100644 --- a/.github/workflows/cifuzz.yml +++ b/.github/workflows/cifuzz.yml @@ -1,5 +1,9 @@ name: CIFuzz on: [pull_request] + +permissions: + contents: read + jobs: Fuzzing: runs-on: ubuntu-latest From 4fe5a75dd6b1cd8ff4e700e6602aea1a00a657d8 Mon Sep 17 00:00:00 2001 From: firewave Date: Sat, 9 Mar 2024 17:05:39 +0100 Subject: [PATCH 6/6] aligned comment headers of all GitHub actions --- .github/workflows/CI-cygwin.yml | 6 ++---- .github/workflows/CI-mingw.yml | 6 ++---- .github/workflows/CI-windows.yml | 6 ++---- .github/workflows/buildman.yml | 2 ++ .github/workflows/cifuzz.yml | 3 +++ .github/workflows/codeql-analysis.yml | 2 ++ .github/workflows/coverity.yml | 3 ++- .github/workflows/cppcheck-premium.yml | 3 ++- .github/workflows/release-windows.yml | 6 ++---- 9 files changed, 19 insertions(+), 18 deletions(-) diff --git a/.github/workflows/CI-cygwin.yml b/.github/workflows/CI-cygwin.yml index 0c7c9baec9b..fe9dcc65445 100644 --- a/.github/workflows/CI-cygwin.yml +++ b/.github/workflows/CI-cygwin.yml @@ -1,7 +1,5 @@ -# Some convenient links: -# - https://github.com/actions/virtual-environments/blob/master/images/win/Windows2019-Readme.md -# - +# Syntax reference https://help.github.com/en/actions/reference/workflow-syntax-for-github-actions +# Environment reference https://help.github.com/en/actions/reference/virtual-environments-for-github-hosted-runners name: CI-cygwin on: diff --git a/.github/workflows/CI-mingw.yml b/.github/workflows/CI-mingw.yml index 6a1b8fde64c..04145d72f89 100644 --- a/.github/workflows/CI-mingw.yml +++ b/.github/workflows/CI-mingw.yml @@ -1,7 +1,5 @@ -# Some convenient links: -# - https://github.com/actions/virtual-environments/blob/master/images/win/Windows2019-Readme.md -# - +# Syntax reference https://help.github.com/en/actions/reference/workflow-syntax-for-github-actions +# Environment reference https://help.github.com/en/actions/reference/virtual-environments-for-github-hosted-runners name: CI-mingw on: diff --git a/.github/workflows/CI-windows.yml b/.github/workflows/CI-windows.yml index 53458b87701..3d0db730702 100644 --- a/.github/workflows/CI-windows.yml +++ b/.github/workflows/CI-windows.yml @@ -1,7 +1,5 @@ -# Some convenient links: -# - https://github.com/actions/virtual-environments/blob/master/images/win/Windows2019-Readme.md -# - +# Syntax reference https://help.github.com/en/actions/reference/workflow-syntax-for-github-actions +# Environment reference https://help.github.com/en/actions/reference/virtual-environments-for-github-hosted-runners name: CI-windows on: diff --git a/.github/workflows/buildman.yml b/.github/workflows/buildman.yml index cb7fc655bee..1d6804715f2 100644 --- a/.github/workflows/buildman.yml +++ b/.github/workflows/buildman.yml @@ -1,3 +1,5 @@ +# Syntax reference https://help.github.com/en/actions/reference/workflow-syntax-for-github-actions +# Environment reference https://help.github.com/en/actions/reference/virtual-environments-for-github-hosted-runners name: Build manual on: diff --git a/.github/workflows/cifuzz.yml b/.github/workflows/cifuzz.yml index 2d2f5f1f237..cfc3bc12966 100644 --- a/.github/workflows/cifuzz.yml +++ b/.github/workflows/cifuzz.yml @@ -1,4 +1,7 @@ +# Syntax reference https://help.github.com/en/actions/reference/workflow-syntax-for-github-actions +# Environment reference https://help.github.com/en/actions/reference/virtual-environments-for-github-hosted-runners name: CIFuzz + on: [pull_request] permissions: diff --git a/.github/workflows/codeql-analysis.yml b/.github/workflows/codeql-analysis.yml index f486cf9e24f..d553598cfc8 100644 --- a/.github/workflows/codeql-analysis.yml +++ b/.github/workflows/codeql-analysis.yml @@ -1,3 +1,5 @@ +# Syntax reference https://help.github.com/en/actions/reference/workflow-syntax-for-github-actions +# Environment reference https://help.github.com/en/actions/reference/virtual-environments-for-github-hosted-runners name: "CodeQL" on: diff --git a/.github/workflows/coverity.yml b/.github/workflows/coverity.yml index 9dad4d443f3..148fc15462d 100644 --- a/.github/workflows/coverity.yml +++ b/.github/workflows/coverity.yml @@ -1,4 +1,5 @@ - +# Syntax reference https://help.github.com/en/actions/reference/workflow-syntax-for-github-actions +# Environment reference https://help.github.com/en/actions/reference/virtual-environments-for-github-hosted-runners name: Coverity on: diff --git a/.github/workflows/cppcheck-premium.yml b/.github/workflows/cppcheck-premium.yml index 9604d29542a..a9b40184726 100644 --- a/.github/workflows/cppcheck-premium.yml +++ b/.github/workflows/cppcheck-premium.yml @@ -1,4 +1,5 @@ - +# Syntax reference https://help.github.com/en/actions/reference/workflow-syntax-for-github-actions +# Environment reference https://help.github.com/en/actions/reference/virtual-environments-for-github-hosted-runners name: cppcheck-premium on: diff --git a/.github/workflows/release-windows.yml b/.github/workflows/release-windows.yml index 2e1d9d7cabd..ca4bbac67d8 100644 --- a/.github/workflows/release-windows.yml +++ b/.github/workflows/release-windows.yml @@ -1,7 +1,5 @@ -# Some convenient links: -# - https://github.com/actions/virtual-environments/blob/master/images/win/Windows2019-Readme.md -# - +# Syntax reference https://help.github.com/en/actions/reference/workflow-syntax-for-github-actions +# Environment reference https://help.github.com/en/actions/reference/virtual-environments-for-github-hosted-runners name: release-windows on: