Skip to content

do not persist checkout credentials in GitHub workflows - #7044

Merged
chrchr-github merged 1 commit into
cppcheck-opensource:mainfrom
firewave:gh-harden
Nov 27, 2024
Merged

chrchr-github merged 1 commit into
cppcheck-opensource:mainfrom
firewave:gh-harden

Conversation

@firewave

Copy link
Copy Markdown
Collaborator

based on zizmor analysis

@firewave

Copy link
Copy Markdown
Collaborator Author

Example:

warning[artipacked]: credential persistence through GitHub Actions artifacts
   --> /mnt/s/GitHub/cppcheck-fw/.github/workflows/CI-unixish.yml:178:9
    |
178 |       - uses: actions/checkout@v4
    |         ------------------------- does not set persist-credentials: false
    |
    = note: audit confidence → Low

See actions/checkout#485 for more context.

@firewave

Copy link
Copy Markdown
Collaborator Author

I filed tickets about addressing the remaining findings:
https://trac.cppcheck.net/ticket/13351
https://trac.cppcheck.net/ticket/13352

@firewave
firewave marked this pull request as ready for review November 26, 2024 22:17
@chrchr-github
chrchr-github merged commit 988c79e into cppcheck-opensource:main Nov 27, 2024
@firewave
firewave deleted the gh-harden branch November 27, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants