From de7fd73d451a58710a6f20ad5f157b1ddeaf665d Mon Sep 17 00:00:00 2001 From: firewave Date: Wed, 23 Nov 2022 21:02:35 +0100 Subject: [PATCH 1/3] address Node.js 12 deprecation warnings in GitHub workflows --- .github/workflows/CI-unixish.yml | 2 +- .github/workflows/CI-windows.yml | 4 ++-- .github/workflows/clang-tidy.yml | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/CI-unixish.yml b/.github/workflows/CI-unixish.yml index a03e1d52..b95db1e5 100644 --- a/.github/workflows/CI-unixish.yml +++ b/.github/workflows/CI-unixish.yml @@ -14,7 +14,7 @@ jobs: runs-on: ${{ matrix.os }} steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 - name: Install missing software on ubuntu if: matrix.os == 'ubuntu-22.04' diff --git a/.github/workflows/CI-windows.yml b/.github/workflows/CI-windows.yml index 220c34a2..aca68c93 100644 --- a/.github/workflows/CI-windows.yml +++ b/.github/workflows/CI-windows.yml @@ -22,10 +22,10 @@ jobs: runs-on: ${{ matrix.os }} steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 - name: Setup msbuild.exe - uses: microsoft/setup-msbuild@v1.0.2 + uses: microsoft/setup-msbuild@v1.1 - name: Run cmake if: matrix.os == 'windows-2019' diff --git a/.github/workflows/clang-tidy.yml b/.github/workflows/clang-tidy.yml index e1594f60..1202f5df 100644 --- a/.github/workflows/clang-tidy.yml +++ b/.github/workflows/clang-tidy.yml @@ -10,7 +10,7 @@ jobs: runs-on: ubuntu-22.04 steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 - name: Install missing software run: | From 529d00f9089069dbb8f3e8520d3bc264daa9e6ac Mon Sep 17 00:00:00 2001 From: firewave Date: Wed, 23 Nov 2022 21:17:24 +0100 Subject: [PATCH 2/3] CI-unixish.yml: removed `ubuntu-18.04` since it has been deprecated --- .github/workflows/CI-unixish.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/CI-unixish.yml b/.github/workflows/CI-unixish.yml index b95db1e5..24d5ec9c 100644 --- a/.github/workflows/CI-unixish.yml +++ b/.github/workflows/CI-unixish.yml @@ -8,7 +8,7 @@ jobs: strategy: matrix: compiler: [clang++, g++] - os: [ubuntu-18.04, ubuntu-20.04, ubuntu-22.04, macos-11, macos-12] + os: [ubuntu-20.04, ubuntu-22.04, macos-11, macos-12] fail-fast: false runs-on: ${{ matrix.os }} From 425732e2704531193fc7a636ccde90d3acc03349 Mon Sep 17 00:00:00 2001 From: firewave Date: Wed, 23 Nov 2022 21:23:40 +0100 Subject: [PATCH 3/3] CI-unixish.yml: fixed check for `libstdc++` debug mode step --- .github/workflows/CI-unixish.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/CI-unixish.yml b/.github/workflows/CI-unixish.yml index 24d5ec9c..d800ae4b 100644 --- a/.github/workflows/CI-unixish.yml +++ b/.github/workflows/CI-unixish.yml @@ -37,7 +37,7 @@ jobs: valgrind --leak-check=full --num-callers=50 --show-reachable=yes --track-origins=yes --gen-suppressions=all --error-exitcode=42 ./testrunner - name: Run with libstdc++ debug mode - if: matrix.os == 'ubuntu-22.04' && matrix.compiler == 'gcc' + if: matrix.os == 'ubuntu-22.04' && matrix.compiler == 'g++' run: | make clean make -j$(nproc) test CXX=${{ matrix.compiler }} CXXFLAGS="-g3 -D_GLIBCXX_DEBUG"