native_readlink #1205
Merged
native_readlink #1205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced `readlinkat` functionality in both POSIX and Win32 environments. - Added new `posix_readlinkat` and `win32_9xa_readlinkat` functions to handle symbolic link resolution. - Updated relevant headers and added error handling for invalid paths. - Enhanced the `dos_readlinkat_impl` to manage DOS-specific behavior for symbolic links. - Included a new example demonstrating the usage of `readlinkat` in `examples/0036.at/readlink.cc`.
…ader - Modified the signature of `concat_tlc_win32_9xa_path_uncheck_whether_exist` to improve clarity and maintain consistency in the codebase.
- Updated error handling in multiple Win32 header files to replace the error code `3221225530` with a more generic error code `3` for invalid DOS filenames. - This change enhances consistency across the error handling mechanisms in the Win32 platform implementation.
- Updated `dos_faccessat` and `native_faccessat` functions to correctly use the `access_how` parameter instead of `dos_at_flags` for mode handling. - Adjusted conditional checks in `nt_at.h` and `win32_9xa_at.h` to ensure proper evaluation of `symlink_nofollow` flag. - Improved clarity and consistency in the handling of file access modes across different platform implementations.
- Added best-effort closing of file descriptors in the destructor and assignment operators to prevent resource leaks. - Improved safety checks for file descriptor validity before closing. - Ensured consistent handling of directory pointers and file descriptors across multiple methods.
- Added a new implementation of `nt_readlinkat_impl` to handle symbolic link resolution in the NT filesystem. - Enhanced error handling for symbolic links, including checks for reparse tags. - Refactored function signatures for consistency and clarity in the handling of directory handles and paths. - Improved overall structure and readability of the code in `nt_at.h`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.