Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move project to cpplint/cpplint #31

Closed
mattyclarkson opened this issue Nov 1, 2016 · 10 comments
Closed

Move project to cpplint/cpplint #31

mattyclarkson opened this issue Nov 1, 2016 · 10 comments

Comments

@mattyclarkson
Copy link
Member

If we move the project to a organisation we can have multiple collaborators on the project and share the maintenance. We use this version of cpplint internally at work and would happily spend time maintaining the project, issues and PRs.

@thomasjo
Copy link

thomasjo commented Nov 2, 2016

Seconded!

@tkruse
Copy link

tkruse commented Nov 2, 2016

So I for one am happy to add @mattyclarkson to the pypi list of people with rights to make releases.
Not sure if @theandrewdavis is very active right now, he might be inclined to just pass on the baton.
We can wait a couple of days for him to reply (ping again if I forget).

An independent github organisation might be overkill for now. My personal vision is for this to remain a close siamese twin of the google upstream, only adding Python3 compatibility and very tiny changes.
For that scope, I think a github organization feels too "big".
However, if @mattyclarkson becomes main maintainer, he is free to decide such matters as well.

@mattyclarkson
Copy link
Member Author

@tkruse, I think it makes the project feel more of a community project rather than one persons project. I don't particularly want to be the sole maintainer but am happy to share the load with a few maintainers. I will generally be available to work on this though as we use it at work.

I agree that we should keep it close to the upstream cpplint as possible 👍

@theandrewdavis
Copy link
Member

theandrewdavis commented Nov 2, 2016

@tkruse is right -- I'm no longer using cpplint at work so I haven't had the motivation to work on it. Would be great if you'd like to take over, @mattyclarkson.

If you'll let me know what your username on pypi is, I'll add you as an owner. And I will update theandrewdavis/cpplint to point to wherever y'all decide cpplint should live (cpplint/cpplint or mattyclarkson/cpplint)

@mattyclarkson
Copy link
Member Author

@theandrewdavis, my user name on PyPi is mattyclarkson. I would prefer if the project moved to cpplint/cpplint so that if the maintainer needs to change again we can just add/remove people from the organisation. I've never moved a personal project to an organisation but when we did it with civetweb/civetweb the owner of that just got in contact with the GitHub support people I think. Having an organisation makes it easier to share the Travis permissions. S'up to you guys though, really.

I'm happy to keep maintaining it whilst we use it at work. Would be nice if a few of you are around to bounce ideas/PRs off.

@thomasjo
Copy link

thomasjo commented Nov 3, 2016

@mattyclarkson No need to involve GitHub staff.

Create the organization, then give @theandrewdavis admin privileges in the organization. He can then trivially transfer the repo to the organization via The Danger Zone™ options,

options

@thomasjo
Copy link

thomasjo commented Nov 3, 2016

@mattyclarkson
Copy link
Member Author

OK have made the organisation. https://github.com/cpplint

How should be part of the organisation team?

@theandrewdavis
Copy link
Member

That was simple enough. You're on the pypi now, @mattyclarkson, and the repo is transferred.

@mattyclarkson
Copy link
Member Author

Rock on 🤘

n3world added a commit to n3world/cpplint that referenced this issue Oct 20, 2022
Add support for specifying no lint on multiple lines using a NOLINTBEGIN
comment to start the block and one or more NOLINTEND comments. Multiple
NOLINTBEGIN comments can stack different categories and the same number
NOLINTEND comments need to be used to re-enable the category.

This is similar to the clang-tidy NOLINTBEGIN/END feature.

Also, add support for specifying multiple categories in a single NOLINT
comment using commas as separators.
n3world added a commit to n3world/cpplint that referenced this issue Oct 20, 2022
Add support for specifying no lint on multiple lines using a NOLINTBEGIN
comment to start the block and one or more NOLINTEND comments. Multiple
NOLINTBEGIN comments can stack different categories and the same number
NOLINTEND comments need to be used to re-enable the category.

This is similar to the clang-tidy NOLINTBEGIN/END feature.

Also, add support for specifying multiple categories in a single NOLINT
comment using commas as separators.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants