From d4291eb94603726a8dd61343314f1032406a231f Mon Sep 17 00:00:00 2001 From: Yegor Bugayenko Date: Thu, 29 Jun 2023 12:39:35 +0300 Subject: [PATCH] #214 rubocop up --- Gemfile | 4 ++-- bin/pdd | 4 ++-- features/step_definitions/steps.rb | 2 +- lib/pdd.rb | 2 +- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/Gemfile b/Gemfile index 225a8bc..a05a668 100644 --- a/Gemfile +++ b/Gemfile @@ -27,8 +27,8 @@ gem 'minitest', '5.16.2', require: false gem 'rake', '13.0.6', require: false gem 'rdoc', '6.4.0', require: false gem 'rspec-rails', '5.1.2', require: false -gem 'rubocop', '1.32.0', require: false -gem 'rubocop-rspec', '2.12.1', require: false +gem 'rubocop', '1.53.1', require: false +gem 'rubocop-rspec', '2.22.0', require: false gem 'simplecov', '0.22.0', require: false gem 'slop', '4.9.2', require: false gem 'xcop', '0.7.1', require: false diff --git a/bin/pdd b/bin/pdd index fb793d9..aa15b88 100755 --- a/bin/pdd +++ b/bin/pdd @@ -40,7 +40,7 @@ begin body = File.read(cfg) extra = body.split(/\s+/).map(&:strip) args += extra - puts "Found #{body.split(/\n/).length} lines in #{File.absolute_path(cfg)}" + puts "Found #{body.split("\n").length} lines in #{File.absolute_path(cfg)}" end args += ARGV @@ -90,7 +90,7 @@ https://github.com/cqfn/pdd/blob/master/README.md" body = File.read(cfg) extra = body.split(/\s+/).map(&:strip) opts['skip-gitignore'] = extra - PDD.log.info "Found #{body.split(/\n/).length} lines in #{File.absolute_path(cfg)}" + PDD.log.info "Found #{body.split("\n").length} lines in #{File.absolute_path(cfg)}" end Encoding.default_external = Encoding::UTF_8 diff --git a/features/step_definitions/steps.rb b/features/step_definitions/steps.rb index 6bfe9c5..fd97516 100644 --- a/features/step_definitions/steps.rb +++ b/features/step_definitions/steps.rb @@ -48,7 +48,7 @@ Given(/^I have a "([^"]*)" file with content:$/) do |file, text| FileUtils.mkdir_p(File.dirname(file)) unless File.exist?(file) File.open(file, 'w:ASCII-8BIT') do |f| - f.write(text.gsub(/\\xFF/, 0xFF.chr)) + f.write(text.gsub('\\xFF', 0xFF.chr)) end end diff --git a/lib/pdd.rb b/lib/pdd.rb index dc2fc11..7da93fd 100644 --- a/lib/pdd.rb +++ b/lib/pdd.rb @@ -145,7 +145,7 @@ def rules(xml) doc = Nokogiri::XML(xml) total = 0 list = @opts[:rule] || [] - unless list.select { |r| r.start_with?('max-duplicates:') }.empty? + unless list.none? { |r| r.start_with?('max-duplicates:') } raise PDD::Error, 'You can\'t modify max-duplicates, it\'s always 1' end