Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pdd is very slow #139

Closed
ribtoks opened this issue Aug 16, 2019 · 6 comments
Closed

pdd is very slow #139

ribtoks opened this issue Aug 16, 2019 · 6 comments

Comments

@ribtoks
Copy link

@ribtoks ribtoks commented Aug 16, 2019

I'm trying to run pdd on the repository https://github.com/ribtoks/xpiks using command pdd -s ./src and it is too slow on my macbook pro.

Even though it does not finish scan (it exited on some non-excluded binary .rc file), it took time measured with a watch time utility

real	1m22.272s
user	0m41.352s
sys	0m28.555s

With this limitation, it is not viable to use this tool for real workflow locally.

Although it sounds sarcastic, in reality it might be easier and faster to replace the pdd with a perl script. Or rewrite using approaches in https://github.com/junegunn/fzf tool - it is capable of finding regexes way faster than pdd while being truly cross-platform and dependency-free (pdd requires ruby runtime and 5 gems).

@0crat
Copy link
Collaborator

@0crat 0crat commented Aug 16, 2019

@yegor256/z please, pay attention to this issue

@0crat
Copy link
Collaborator

@0crat 0crat commented Aug 16, 2019

@ribtoks/z this project will fix the problem faster if you donate a few dollars to it; just click here and pay via Stripe, it's very fast, convenient and appreciated; thanks a lot!

@ribtoks
Copy link
Author

@ribtoks ribtoks commented Aug 19, 2019

I wrote a tool in Go in a couple of hours that does the same as pdd in less than 1 second (on my machine) on the same codebase. You can close the issue if you think 1.5 minutes execution time is OK for your tool.

@yegor256
Copy link
Member

@yegor256 yegor256 commented Oct 10, 2019

@ribtoks but this tool not only scans files but also validates what it finds, performs a number of checks, and creates a multi-level XML document. I'm sure it's possible to make it faster, but it's not a simple scanner. Anyway, I like the tool you created!

@yegor256 yegor256 closed this Oct 10, 2019
@0crat
Copy link
Collaborator

@0crat 0crat commented Oct 10, 2019

Job gh:yegor256/pdd#139 is not assigned, can't get performer

@0crat
Copy link
Collaborator

@0crat 0crat commented Oct 10, 2019

This job is not in scope

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants