Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fixedToolbar as a setting for BaseElementIndex to explicitly define vs using context #1504

Closed
nateiler opened this issue Mar 13, 2017 · 0 comments
Assignees
Labels
enhancement improvements to existing features

Comments

@nateiler
Copy link
Contributor

Currently the toolbar is fixed based on the 'context'.

if (this.settings.context == 'index' && !Garnish.isMobileBrowser(true)) {
     this.addListener(Garnish.$win, 'resize,scroll', 'updateFixedToolbar');
}

It would be nice to explicitly define whether the toolbar should be fixed or not via a setting such as:

if (this.settings.toolbarFixed && !Garnish.isMobileBrowser(true)) {
     this.addListener(Garnish.$win, 'resize,scroll', 'updateFixedToolbar');
}

I can make a pull request if it would be helpful.

@brandonkelly brandonkelly added the enhancement improvements to existing features label Mar 20, 2017
@brandonkelly brandonkelly self-assigned this Mar 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement improvements to existing features
Projects
None yet
Development

No branches or pull requests

2 participants