Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isImageManipulatable looking for sample.pdf #1648

Closed
shoeshine opened this issue Apr 20, 2017 · 1 comment

Comments

Projects
None yet
3 participants
@ghost
Copy link

commented Apr 20, 2017

Description

Logs have this repeated item:
screen_shot_2017-04-20_at_15 24 58

Line 59 of craft/app/helpers/ImageHelper.php seems to be the culprit.

public static function isImageManipulatable($extension)
    {
        $path = craft()->path->getResourcesPath();
        $file = $path."images/samples/sample.".StringHelper::toLowerCase($extension);

        try
        {
            craft()->images->loadImage($file);
            return true;
        }
        catch(\Exception $e)
        {
            return false;
        }
    }

Additional info

  • Craft version: 2.6.2973
  • PHP version: 5.4.13 and 7.0.15
  • Database driver & version: MySQL
@angrybrad

This comment has been minimized.

Copy link
Member

commented Apr 20, 2017

Several places in the code that call this and only a few of them check to make sure if it's an image type first. They probably all should. Not actually a bug, just unnecessary noise in the logs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.