Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] #content-container width not properly restricted in Firefox #3071

Closed
ghost opened this issue Jul 5, 2018 · 9 comments

Comments

Projects
None yet
3 participants
@ghost
Copy link

commented Jul 5, 2018

I have some matrix blocks with a lot of content. When collapsing them the collapsed block runs way too long so it hides it's context menu beyond the viewport in Firefox.

I fixed this locally by adding overflow: hidden to #content-container but I did not properly test this. I hope this helps.

@brandonkelly

This comment has been minimized.

Copy link
Member

commented Jul 5, 2018

What version of Craft are you running?

@ghost

This comment has been minimized.

Copy link
Author

commented Jul 5, 2018

Craft 3 latest.

@ghost

This comment has been minimized.

Copy link
Author

commented Jul 5, 2018

image

image

In the second image I added the overflow: hidden and now it displays fine.

@tpmatthes

This comment has been minimized.

Copy link

commented Jul 6, 2018

This also happens, if you have a lot of tabs:

firefox hidden sidebar

The mobile view (< 1000 px) works just fine.

Firefox 61.0.1 and Craft Pro 3.0.14

@johnwbaxter

This comment has been minimized.

Copy link

commented Jul 7, 2018

I have the same issue, but only 2 tabs and only 4 matrix blocks so not sure it's the quantity of these at fault!

However, i do have a fair few matrix types and when this issue happens, they haven't been condensed into a single dropdown, so, i'd guess a JS issue here.

See attached for console output.
screen shot 2018-07-07 at 13 01 33

@brandonkelly

This comment has been minimized.

Copy link
Member

commented Jul 8, 2018

This should be fixed now for the next release. I wasn’t able to reproduce the tab issue, but suspect it’s related. If you have a chance, you can test by opening composer.json and changing the craftcms/cms constraint to "dev-develop as 3.0.14", and then run composer update.

@tpmatthes

This comment has been minimized.

Copy link

commented Jul 8, 2018

Regarding the tab issue: I’ve just tested it with dev-develop and everything works fine again. Thanks for your help! 👍

@ghost

This comment has been minimized.

Copy link
Author

commented Jul 8, 2018

dev-develop works for me as well. Thanks for your work!

@brandonkelly

This comment has been minimized.

Copy link
Member

commented Jul 8, 2018

Great – thanks for testing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.