Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim whitespace on user submission for email host name #3459

Closed
KatieMFritz opened this issue Nov 9, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@KatieMFritz
Copy link
Contributor

commented Nov 9, 2018

Description

I just spent a while troubleshooting SMTP email setup, when part of my problem was that I had pasted a trailing space at the end of my host name. It would be cool if that field automatically trimmed whitespace at the start or end of the string. I can't think of a case where whitespace would be needed - can you?

Steps to reproduce

  1. Paste host name with trailing space that you don't notice.
  2. Troubleshoot fruitlessly for a while.
  3. Think "what if there's a trailing space?"
  4. Discover trailing space and delete it.
  5. Successfully send test email.
  6. Ask Craft to save future devs from this cycle.
    😘

screen shot 2018-11-09 at 12 23 00 pm

Additional info

  • Craft version: 3.0.30.2
@brandonkelly

This comment has been minimized.

Copy link
Member

commented Nov 12, 2018

Thanks for the suggestion. Done for tomorrow’s release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.