Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default entry status ignored, always enabled #3791

Closed
skoften opened this issue Feb 6, 2019 · 10 comments

Comments

Projects
None yet
3 participants
@skoften
Copy link

commented Feb 6, 2019

Ok so I added a second site yesterday and now the default entry status in the section configuration seems to be ignored; the entry is always enabled by default.

I tested it on another install with only 1 site configured and this seem to work fine. So probably only an issue in case of a multi site configuration?

Running Craft CMS 3.1.8

@brandonkelly

This comment has been minimized.

Copy link
Member

commented Feb 6, 2019

Is it being ignored by existing entries or brand new entries, or both?

@skoften

This comment has been minimized.

Copy link
Author

commented Feb 6, 2019

It's ignored when creating a new entry; I have to switch it manually to disabled, but the default status in the section is set to disabled. Used to work fine, but after adding a second site this changed.

@brandonkelly

This comment has been minimized.

Copy link
Member

commented Feb 7, 2019

I’m not able to reproduce that. New entries are enabled/disabled for each site in accordance with the section’s settings.

Can you please contact us from your Craft Support widget on your Dashboard, and reference this GitHub issue URL?

@mark-chief

This comment has been minimized.

Copy link

commented Feb 8, 2019

Same for me.

I changed the setting on an existing Section, and new entries are not reflecting the change and are enabled by default.

Craft Pro v3.1.8
PHP v7.2

screen shot 2019-02-08 at 10 19 22

screen shot 2019-02-08 at 10 18 33

@brandonkelly

This comment has been minimized.

Copy link
Member

commented Feb 8, 2019

Ahhh, OK I’m able to reproduce when “Propagate entries across all enabled sites?” is disabled.

@brandonkelly

This comment has been minimized.

Copy link
Member

commented Feb 8, 2019

Fixed for the next release.

@skoften

This comment has been minimized.

Copy link
Author

commented Feb 8, 2019

Hm, I updated the EntriesController.php with your changes, but it doesn't seem to have any effect; the default status is still enabled.

screenshot 2019-02-08 at 12 27 04

screenshot 2019-02-08 at 12 27 36

brandonkelly added a commit that referenced this issue Feb 8, 2019

@brandonkelly

This comment has been minimized.

Copy link
Member

commented Feb 8, 2019

@skoften Yeah you’re right. The fix only worked for sections with more than one enabled site. Just implemented a better fix that seems to be working correctly across all the different scenarios.

Rather than editing the code manually, you can test the fix early by editing your craftcms/cms requirement in composer.json:

"require": {
  "craftcms/cms": "dev-develop#6680a10a1fe4de0516d027272a88f67dfca25a6f as 3.1.8",
  "...": "..."
}

Then go to your project in your terminal and run composer update.

@skoften

This comment has been minimized.

Copy link
Author

commented Feb 8, 2019

Thanks! But I can't test it though, because I get an 503 after updating with that development version;

screenshot 2019-02-08 at 15 13 36

@brandonkelly

This comment has been minimized.

Copy link
Member

commented Feb 8, 2019

That should only happen on the front-end. If you visit your Control Panel you should be given the opportunity to run the new migrations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.