Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Special chars in slugs please not based on CP language #3820

Closed
davidhellmann opened this issue Feb 11, 2019 · 7 comments

Comments

Projects
None yet
3 participants
@davidhellmann
Copy link

commented Feb 11, 2019

Description

The slug special chars work different in relation to the cp language. It's a problem for me. We use mostly EN as CP language but now, the slugs are incorrect (möchte => mochte) this are totally different meanings for this word. When I change the language to german it's fine. But why is the special char handling not the same for alle cp languages? Can't find a setting to handle that for slugs particular.

Steps to reproduce

  1. Use german as CP lang => all fine (möchte => moechte)
  2. Use english as CP lang => broken (möchte => mochte)

Additional info

  • Craft version: 3.1.8
  • PHP version: 7.2
@carlcs

This comment has been minimized.

Copy link
Contributor

commented Feb 11, 2019

Yeah I think it should use the language of the site you’re currently editing the entry for. Doesn’t make sense to use the current user’s language (what @davidhellmann means with CP language).

@davidhellmann

This comment has been minimized.

Copy link
Author

commented Feb 11, 2019

Yes, site language is more clear as cp lang.

@brandonkelly

This comment has been minimized.

Copy link
Member

commented Feb 12, 2019

Fixed this for the next release.

@davidhellmann

This comment has been minimized.

Copy link
Author

commented Feb 12, 2019

Thanks brandon!

@davidhellmann

This comment has been minimized.

Copy link
Author

commented Mar 11, 2019

@brandonkelly another issue related to this is the search within the CP. When I search for something like österreich with a german umlaut in it I get null results. Maybe it can be also related to the matching site?

@brandonkelly

This comment has been minimized.

Copy link
Member

commented Mar 12, 2019

@davidhellmann Can you post a new issue please?

@davidhellmann

This comment has been minimized.

Copy link
Author

commented Mar 12, 2019

Sure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.