Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyphens no longer removed from default asset titles #4011

Closed
elivz opened this issue Mar 19, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@elivz
Copy link

commented Mar 19, 2019

It used to be (unless I'm going crazy) that the default title for an uploaded asset would have any hyphens changed to spaces. So the file "this-is-a-photo.jpeg" would be given the default title "This is a photo". Recently, that seems to have been changed, so now you would end up with "This-is-a-photo".....significantly less nice, imho.

I believe that change was introduced in this commit. Seems like it might be as simple as just changing line 181 in the filename2String() function to:

return StringHelper::upperCaseFirst(implode(' ', StringHelper::toWords($filename, false, true)));

Or maybe this was an intentional change, but it leads to a lot of junk-looking image titles in e.g. Google Image Search results.

@brandonkelly

This comment has been minimized.

Copy link
Member

commented Mar 19, 2019

Yeah this seems like an oversight. Made the change you recommended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.