Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Element Index enhancements #4292

Open
nateiler opened this issue May 21, 2019 · 2 comments

Comments

Projects
None yet
2 participants
@nateiler
Copy link
Contributor

commented May 21, 2019

We're using element indexes in various ways. However, there is a limitation with configuring the index settings which can only be assigned per Element Type. I'm proposing to a 'context' column (defaulting to 'index') to 'elementindexsettings' table. As a result, settings could be configured as various 'contexts'.

I've stepped through about 90% of what this would touch, and there are no breaking changes. I'm happy to put together a pull request if it's worth entertaining.

@brandonkelly

This comment has been minimized.

Copy link
Member

commented May 21, 2019

How would not-index context settings be managed? Would they default to the index settings?

@nateiler

This comment has been minimized.

Copy link
Contributor Author

commented May 22, 2019

How would not-index context settings be managed?

To not put a lot of burden on the core team nor introduce a lot of changes that isn't on the current roadmap, I would leave this up to third-party devs to implement if they so choose.

Would they default to the index settings?

Correct. If a context doesn't exist, default to index.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.