Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image editor crop constraints only let you crop landscapes #4359

Open
johandouma opened this issue Jun 4, 2019 · 1 comment

Comments

Projects
None yet
3 participants
@johandouma
Copy link

commented Jun 4, 2019

Description

When using constrained cropping in the image editor, it only gives me landscape options, ie 16/9, 4/3, 3/2 etc... but as far as I can see, there are no options to swap the orientation to portrait, ie 9/16, 3/4, 2/3 etc... So I need to rotate the picture 90 degrees first, then crop it, then rotate it back 90 degrees, which is very tedious. If it's possible at all without rotating the pictures first, I can't find how to do it.

Steps to reproduce

  1. Edit an asset
  2. Go to the crop tool
  3. Select constraint
  4. Try to crop something to a portrait size

Additional info

  • Craft version: 3.1.28
  • PHP version: 7.3.4
  • Database driver & version: MySQL
  • Plugins & versions:
    Amazon S3 1.2.2
    Asset Rev 6.0.2
    AsyncQueue 2.0.0
    CP Field Inspect 1.0.5
    Calendar Links 1.0.1
    Dumper 1.3.1
    Expanded Singles 1.0.7
    Hutsixassets 0.3.3
    Imager v2.1.10
    Migration Manager 3.0.22
    NSM Fields 0.0.14
    Position Fieldtype 1.0.14
    Redactor 2.3.3.2
    Redirect plugin for Craft 3 1.0.23
    Simple Sharing 1.0.4
    Super Table 2.1.20
    Table Maker 2.0.1
    Typed link field 1.0.19
    Wordsmith 3.0.5
    XML Sitemap 1.0.9
@brandonkelly

This comment has been minimized.

Copy link
Member

commented Jun 5, 2019

Here’s what I think we should do, @andris-sevcenko:

  • Move the aspect ratio menu to its own line, separate from Focal Point
  • When something besides Unconstrained, Original, or Square is selected, add an orientation selector beside it, similar to Photos.app:
    Aspect ratio options in Photos
  • While you’re at it, maybe worth adding a “Custom…” option to the menu as well. When selected, two small text inputs should be added next to the menu (size=3) with a : between them, default values set to 1 and 1 (square). Each time either of the values change to a valid aspect ratio, update the crop tool as if a normal option had been selected. (The orientation selector would not be visible when “Custom…” is selected, by the way.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.