Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.2] Saving via Cmd+S causes Update Entry button to lock #4519

Closed
gregorterrill opened this issue Jul 10, 2019 · 6 comments

Comments

Projects
None yet
5 participants
@gregorterrill
Copy link

commented Jul 10, 2019

Description

In 3.2, when saving an entry using Cmd+S, you can sometimes get stuck in a Draft with the "Update Entry" button greyed out even though the draft has unpublished changes. You then have to switch to another revision and then back to the draft to publish it.

This does not happen if you only save using the Update Entry button - I believe this happens only if you press Cmd+S while a previous save is still in progress (so if you try to do back-to-back saves quickly).

Steps to reproduce

  • Make a field change
  • Press Cmd+S / Ctrl+S to save
  • Make a field change
  • Press Cmd+S / Ctrl+S to save before the first save completes

Additional info

Craft version: 3.2
PHP version: 7.1.18
Database driver & version: MySQL 5.7.21

@clarknelson

This comment has been minimized.

Copy link

commented Jul 10, 2019

i'm also experiencing this :)

@nathanedwards

This comment has been minimized.

Copy link

commented Jul 10, 2019

I'm also getting this, but just to add to the diagnosis I can also recreate the issue reliably by quickly creating a new post, writing something in a field, CMD+S to save, and then because autosave is already whirring away, I get the Chrome notification to say "Are you sure you want to navigate away from this page?

My reflex has sometimes been to click cancel and at that point, the button greys out, I'm unable to save via that method. The Autosave completes so the content is there, but the flow is ruined somewhat. I wonder if CMD+S should always just cancel the Autosave AJAX, since you're posting a save anyway?

@cityzen

This comment has been minimized.

Copy link

commented Jul 17, 2019

Having issues with this as well. If I create a new entry and try to do "Save and add another" I get the js "are you sure you want to leave" message and the entry doesn't get saved. Now I have to add an entry and just click Save Entry and then click save and create new. Otherwise I have to save, click entries, New entry, etc.

@brandonkelly

This comment has been minimized.

Copy link
Member

commented Jul 17, 2019

This should be mostly resolved in Craft 3.2.4.

@gregorterrill

This comment has been minimized.

Copy link
Author

commented Jul 17, 2019

Can confirm, I'm not having any problems with this in 3.2.4.

@brandonkelly

This comment has been minimized.

Copy link
Member

commented Jul 17, 2019

Sweet!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.