Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.2] Getting stuck in a state where it's not possible to save new entries when dragging files onto an asset field #4534

Closed
aelvan opened this issue Jul 11, 2019 · 6 comments

Comments

Projects
None yet
3 participants
@aelvan
Copy link

commented Jul 11, 2019

Steps to reproduce

  1. Create a section that has an entry type with an asset field.
  2. Create a new entry.
  3. Add a title, and drag a file onto the asset field.
  4. Click "Save entry". The browser (Chrome in my case) pops up a message saying "Leave site? Changes you made may not be saved.". That doesn't sound right, so click "Cancel".

The "Save entry" button is now disabled, and changing the content does not enable it. I've not found a way to save the entry successfully after this happens.

Additional info

  • Craft version: 3.2.0
  • PHP version: 7.2.14
  • Database driver & version: 5.7.25
@brandonkelly

This comment has been minimized.

Copy link
Member

commented Jul 11, 2019

Can you test this in 3.2.1? A couple of possibly-related bugs were fixed in that.

@aelvan

This comment has been minimized.

Copy link
Author

commented Jul 11, 2019

Just tested on 3.2.1 and the issue is still there.

@brandonkelly

This comment has been minimized.

Copy link
Member

commented Jul 11, 2019

Thanks! I’m not able to reproduce this though. What are your Assets field settings? Are you getting any JavaScript errors on the page?

@mmikkel

This comment has been minimized.

Copy link

commented Jul 12, 2019

@brandonkelly I'm able to reproduce this (also using Chrome on Mac). There are no JS errors in the console, and it only happens if you drag a file to the Assets field, not if you actually click "Add an Asset".

I made a quick screencast to demo the issue: https://recordit.co/YFEj4QyRYq

@aelvan

This comment has been minimized.

Copy link
Author

commented Jul 12, 2019

I tried changing the Asset field settings around, but that doesn't make any difference. I'm able to reproduce with no restrictions to folder, all sources enabled, no restrictions to file types, limit of 1, and no validation of related assets. No errors in the console.

Here's a recording that shows what I'm doing: https://recordit.co/3iyrYB2UXm

@brandonkelly

This comment has been minimized.

Copy link
Member

commented Jul 12, 2019

Thanks for the videos! I noticed that there was no spinner in the header, after the upload had completed, which means that Craft didn’t realize that the form had changed. Fixed that for the next release.

To get the fix early, change your craftcms/cms requirement in composer.json to:

"require": {
  "craftcms/cms": "dev-develop#a303b5c3043d6c77f09c01230aa88135c603694d as 3.2.1",
  "...": "..."
}

Then run composer update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.