Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server becomes unresponsive due to GIF transforms performed in control panel #4588

Closed
aaronbushnell opened this issue Jul 17, 2019 · 9 comments

Comments

@aaronbushnell
Copy link
Contributor

commented Jul 17, 2019

Description

The transformGifs config has helped us a lot to avoid a large GIF getting transformed on the front-end on the site and exhausting server resources. But it still seems like GIFs are still getting transformed even after the changes added in #3110.

On one particularly GIF-heavy site—if I visit the "Assets" area a list view of 5-10 GIFs ends up locking down the site until all resources are exhausted and it crashes.

If I add a

return "";

at the beginning of the getThumbPath() function it doesn't seem to be an issue. So I wonder if GIFs are still getting transformed in some way that's eating up server resources?

Additional info

  • PHP Version: 7.0.33
  • Database: MySQL 5.7.26
  • Craft Version: Craft Pro 3.2.3
  • Image Driver: Imagick 3.4.0RC6 (ImageMagick 6.8.9-9)
@andris-sevcenko

This comment has been minimized.

Copy link
Member

commented Jul 19, 2019

Well, this is a fun trip down the rabbit hole. By any chance, do you also have set the optimizeImageFilesize setting to false in your Craft config?

@andris-sevcenko

This comment has been minimized.

Copy link
Member

commented Jul 19, 2019

Never mind, that was an unrelated issue. I found your bug, sir.

@aaronbushnell

This comment has been minimized.

Copy link
Contributor Author

commented Jul 19, 2019

Ah man, thanks so much @andris-sevcenko! I applied this change to the site and it seems like it's no longer an issue!

@andris-sevcenko

This comment has been minimized.

Copy link
Member

commented Jul 19, 2019

You're welcome! Now to fix the other bug I found... :)

brandonkelly added a commit that referenced this issue Jul 19, 2019
@aaronbushnell

This comment has been minimized.

Copy link
Contributor Author

commented Jul 22, 2019

Hey @andris-sevcenko — you might have seen this already but it looks like Brandon's change here undid the fix that corrected the slow GIF transformation. After updating to the latest version it looks like the slowness is re-occurring on our site. Not sure if there's another fix that could be implemented here?

@andris-sevcenko

This comment has been minimized.

Copy link
Member

commented Jul 22, 2019

@aaronbushnell yeah we have to release a new version of Imagine on our fork so it doesn't break in some other circumstances. Should be out this week definitely, I'll keep you posted!

@aaronbushnell

This comment has been minimized.

Copy link
Contributor Author

commented Jul 23, 2019

Totally okay! Appreciate the help and let me know if I can test anything for ya!

@brandonkelly

This comment has been minimized.

Copy link
Member

commented Jul 23, 2019

We just released Craft 3.2.6 with the fix for this.

@aaronbushnell

This comment has been minimized.

Copy link
Contributor Author

commented Jul 23, 2019

You all are awesome—thanks a ton!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.