Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make "share" button into link again #4891

Open
piotrpog opened this issue Sep 5, 2019 · 5 comments

Comments

@piotrpog
Copy link

commented Sep 5, 2019

Can "share" button visible in entry editing page be made into link again?

Out of habit i keep clicking on it with middle mouse button.

@brandonkelly

This comment has been minimized.

Copy link
Member

commented Sep 5, 2019

It acts as a link unless there is more than one share target, in which case it becomes a menu button.

@piotrpog

This comment has been minimized.

Copy link
Author

commented Sep 7, 2019

@brandonkelly
I never added any preview targets (fresh install) and the button still does not act as link.

@brandonkelly

This comment has been minimized.

Copy link
Member

commented Sep 8, 2019

What does it do, then?

@Mosnar

This comment has been minimized.

Copy link
Contributor

commented Sep 8, 2019

@brandonkelly I think he means it's not an anchor tag, but a div with a click handler on it, so he can't middle-click or right click and open in a new tab. I was able to confirm that the share button is always a div, regardless of whether there are preview targets or not.

Prior to 3.3, the share button was an anchor tag.

@piotrpog

This comment has been minimized.

Copy link
Author

commented Sep 8, 2019

@Mosnar @brandonkelly
Yes, thats what I meant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.