Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matrix field gets emptied on saving in preview mode #5217

Closed
diluno opened this issue Nov 7, 2019 · 7 comments

Comments

@diluno
Copy link

@diluno diluno commented Nov 7, 2019

Description

When I press Cmd+S in live preview mode, an entire matrix field just loses all its content.
Screen capture: https://drive.google.com/open?id=1iUdYkfkAElp44HlLE0uMRptcyOIDBuba

Steps to reproduce

  1. Create matrix field in a section (in a second tab)
  2. Open Live Preview
  3. Press Cmd+S
  4. Content disappears

Additional info

  • Craft version: 3.4.x-dev (d10c55d)
  • PHP version: 7.1.32
  • Database driver & version: MySQL 5.7.27
  • Plugins & versions:
    DigitalOcean Spaces Volume 1.1.2
    Element API 2.6.0
    Redactor 2.4.0
    Super Table 2.3.0
@brandonkelly

This comment has been minimized.

Copy link
Member

@brandonkelly brandonkelly commented Nov 8, 2019

Yikes, I can reproduce. Will get that fixed!

brandonkelly added a commit that referenced this issue Nov 8, 2019
@brandonkelly

This comment has been minimized.

Copy link
Member

@brandonkelly brandonkelly commented Nov 8, 2019

Alright just fixed this on the 3.4 branch. In composer.json, if you have a specific commit hash in your craftcms/cms requirement, go ahead and remove that, so it looks like this:

"require": {
  "craftcms/cms": "3.4.x-dev",
  "...": "..."
}

Then run composer update.

@diluno

This comment has been minimized.

Copy link
Author

@diluno diluno commented Nov 11, 2019

@brandonkelly My matrix fields are now being saved, but the asset fields within them aren't. Can you reproduce this?

@diluno

This comment has been minimized.

Copy link
Author

@diluno diluno commented Nov 11, 2019

When I save an entry in live preview, it removes all chosen assets. If i then choose new assets and save again, it removes all matrix blocks.
I know it's my fault for upgrading to 3.4.x-dev, but I hope you can fix this soon 🙈
Thank you!

@Mosnar

This comment has been minimized.

Copy link
Contributor

@Mosnar Mosnar commented Nov 12, 2019

@diluno Have you tried clearing your CP cache? In my test environment, I've been seeing stuff like this until I do that and then it seems to work.

@diluno

This comment has been minimized.

Copy link
Author

@diluno diluno commented Nov 12, 2019

@Mosnar This didn't help, unfortunately.

@brandonkelly

This comment has been minimized.

Copy link
Member

@brandonkelly brandonkelly commented Nov 22, 2019

Fixed a couple more bugs with relation field saving (7a69656). Should be all good now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.