Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMS Utilities Updates page no longer showing updates [Firefox] #5321

Open
qrazi opened this issue Dec 10, 2019 · 4 comments
Open

CMS Utilities Updates page no longer showing updates [Firefox] #5321

qrazi opened this issue Dec 10, 2019 · 4 comments

Comments

@qrazi
Copy link
Contributor

@qrazi qrazi commented Dec 10, 2019

Description

When trying to see available updates, the loading icon just keeps indicating loading. The inspector shows a JavaScript error.

Steps to reproduce

  1. Clean install Craft CMS 3.3.17
  2. Login CMS
  3. Go to Utilities -> Updates
  4. See "Checking for updates..." plus loading icon
  5. Open browser inspector
  6. See "TypeError: e.updates is undefined" in UpdatesUtility.js:29:24

Additional info

  • Craft version: 3.3.17 (also tested in existing project on versions 3.3.16.1 & 3.3.16.3)
  • PHP version: 7.2
  • Database driver & version: MySQL 5.7.27
  • Plugins & versions: none

Edit: Just now figured out this is an issue with at least Firefox Developer Edition 72.0b4, the issue cannot be reproduced in Chrome 78.0.3904.108

@qrazi qrazi changed the title CMS Utilities Updates page no longer showing updates CMS Utilities Updates page no longer showing updates [Firefox] Dec 10, 2019
@brandonkelly

This comment has been minimized.

Copy link
Member

@brandonkelly brandonkelly commented Dec 10, 2019

I’m not able to reproduce this with the same browser/version. Any chance you can send an admin account’s credentials, plus SSH access, over to support@craftcms.com?

@qrazi

This comment has been minimized.

Copy link
Contributor Author

@qrazi qrazi commented Dec 11, 2019

Let me setup the clean install on one of my droplets and try and reproduce there. As you could not reproduce, this could very well be an issue with one of my add-ons, one of the ad-blockers perhaps.

@qrazi

This comment has been minimized.

Copy link
Contributor Author

@qrazi qrazi commented Dec 12, 2019

Ok, it turned out to indeed be one of my ad-blockers, EFF's Privacy Badger addon. The default setting for the https://api.craftcms.com domain for me was set to blocking:

image

Changing the setting to "only block cookies, but not the actual requests" (middle slider setting) is enough to have the update page working again... So, not an issue with Craft CMS

Edit: I'll check what I can do with https://www.eff.org/privacybadger/faq#Does-Privacy-Badger-contain-a-%22black-list%22-of-blocked-sites

@brandonkelly

This comment has been minimized.

Copy link
Member

@brandonkelly brandonkelly commented Dec 13, 2019

I suspect this is due to the Google Analytics tracking cookie that you get when visiting https://craftcms.com. Looking into how to get that cookie domain to be just craftcms.com instead of .craftcms.com, but GA seems a little insistent on adding that ., even if I explicitly set cookieDomain: 'craftcms.com'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.