Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] Start Clear Caches page with most/all options UNchecked #5418

Open
proimage opened this issue Jan 10, 2020 · 3 comments
Open

[Suggestion] Start Clear Caches page with most/all options UNchecked #5418

proimage opened this issue Jan 10, 2020 · 3 comments

Comments

@proimage
Copy link

@proimage proimage commented Jan 10, 2020

This suggestion comes from the situation I've encountered where someone wants clear the template cache, and will just click the red "Clear Caches" button for All The Things™, in the process wiping out all the image transforms and putting an incredible load on the server tasked with regenerating them all.

Making all checkboxes unchecked by default (with the button disabled until at least one is checked) would go a long way towards reducing the likelihood of an inadvertent full cache wipe.

Misc thoughts:

  1. You could mark the more high-impact options with a warning symbol & associated tooltip text to explain what the repercussions could be.
  2. In fact, adding short explanations on that page would be quite welcome regardless of checkboxes being checked or not—what's the difference between "Compiled templates" and "Template caches", what are "Control Panel resources", what are all the "Asset ____ ____" options, and what is the very generic-sounding "Data cache", etc.
  3. You could split up the checkboxes into categories based on low/med/high impact and/or commonly-used vs rarely-used.
  4. There should obviously be a way for plugins to follow suit with any changes here (thinking of Imager, mainly).
  5. Perhaps in a Settings page, the devs could specify which checkboxes are checked/unchecked by default for users?

Thanks!

brandonkelly added a commit that referenced this issue Jan 13, 2020
@brandonkelly

This comment has been minimized.

Copy link
Member

@brandonkelly brandonkelly commented Jan 13, 2020

This is sortof related to #1155.

I think a better route for both of these would be to have the utility start remembering what was previously selected, and use that as a starting point.

2. fact, adding short explanations on that page would be quite welcome regardless of checkboxes being checked or not—what's the difference between "Compiled templates" and "Template caches", what are "Control Panel resources", what are all the "Asset ____ ____" options, and what is the very generic-sounding "Data cache", etc.

Just added this for the next 3.4 release.

The Clear Caches utility with an info heads-up display shown for “Asset caches”

@proimage

This comment has been minimized.

Copy link
Author

@proimage proimage commented Jan 14, 2020

Ok, so would remembering previous selections be stored on a per-user basis?

Also, I think there is still value to selecting reasonable (low impact) defaults as the initial state.

Finally, it looks like those icons need their line-height / vertical-align adjusted; they're knocking off the checkbox/text alignment. ;)

@brandonkelly

This comment has been minimized.

Copy link
Member

@brandonkelly brandonkelly commented Jan 14, 2020

Finally, it looks like those icons need their line-height / vertical-align adjusted; they're knocking off the checkbox/text alignment. ;)

Whoops, not sure how I missed that! Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.