Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

customer_discountuse Table does not exist #621

Closed
TheFox opened this Issue Jan 8, 2019 · 2 comments

Comments

Projects
None yet
2 participants
@TheFox
Copy link

TheFox commented Jan 8, 2019

In src/services/Discounts.php, line 535, commerce_customer_discountuse is wrong. This tables doesn't exist.

@TheFox

This comment has been minimized.

Copy link
Author

TheFox commented Jan 10, 2019

Did you even test this? This is wrong since over one year. There is no table called commerce_customer_discountuse. Why do you not use CustomerDiscountUse::tableName() instead of writing '{{%commerce_customer_discountuse}}'?

Why even writing the table name from scratch when you could use the tableName() from each class.

TheFox added a commit to DigitalsunrayMedia/commerce that referenced this issue Jan 10, 2019

TheFox added a commit to DigitalsunrayMedia/commerce that referenced this issue Jan 10, 2019

@lukeholder lukeholder added the bug label Jan 11, 2019

@lukeholder

This comment has been minimized.

Copy link
Member

lukeholder commented Jan 11, 2019

Thanks for the Pull Request, we will be consistent for now and use the string version of the table name. If Craft CMS core switches to the tableName() we also will do so.

Fixed in 8ba2331

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.