Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

customer_discountuse Table does not exist #621

Closed
TheFox opened this issue Jan 8, 2019 · 2 comments
Closed

customer_discountuse Table does not exist #621

TheFox opened this issue Jan 8, 2019 · 2 comments
Labels

Comments

@TheFox
Copy link

@TheFox TheFox commented Jan 8, 2019

In src/services/Discounts.php, line 535, commerce_customer_discountuse is wrong. This tables doesn't exist.

@TheFox
Copy link
Author

@TheFox TheFox commented Jan 10, 2019

Did you even test this? This is wrong since over one year. There is no table called commerce_customer_discountuse. Why do you not use CustomerDiscountUse::tableName() instead of writing '{{%commerce_customer_discountuse}}'?

Why even writing the table name from scratch when you could use the tableName() from each class.

TheFox added a commit to DigitalsunrayMedia/commerce that referenced this issue Jan 10, 2019
TheFox added a commit to DigitalsunrayMedia/commerce that referenced this issue Jan 10, 2019
@lukeholder
Copy link
Member

@lukeholder lukeholder commented Jan 11, 2019

Thanks for the Pull Request, we will be consistent for now and use the string version of the table name. If Craft CMS core switches to the tableName() we also will do so.

Fixed in 8ba2331

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants