Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed return value for actionSaveSettings #39

Closed
wants to merge 1 commit into from

Conversation

vnali
Copy link
Contributor

@vnali vnali commented Nov 10, 2022

Description
saving API Connection tab without filling inputs throws an error
craft\shopify\controllers\SettingsController::actionSaveSettings(): Return value must be of type yii\web\Response, null returned

this PR adds null to accepted return values.

@AugustMiller
Copy link
Contributor

Hey, thanks for the report and patch! We had a couple more related items come up that we wanted to patch, but your changes have been incorporated into #40.

The only difference is that we've opted for craft\web\Response return types, and only made it nullable on the actionSaveSettings method, as actionIndex should always return a rendered template.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants