New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[studio] Refactor the dep calc #1638

Closed
sumerjabri opened this Issue Nov 21, 2017 · 4 comments

Comments

@sumerjabri
Member

sumerjabri commented Nov 21, 2017

Per our conversation, please refactor to:

build_publish_package(x) {
	array publish_package;

	deps = scan x for dependencies

	for dep in deps {
		if (dep is new || (dep is 'edited' && dep is item_specific)) {
			publish_package.add(dep);
			publish_package.add(build_publish_package(dep));
		}
	}

	return publish_package;
}

@sumerjabri sumerjabri added this to the Crafter CMS v3.0.2 milestone Nov 21, 2017

@sumerjabri sumerjabri added this to Backlog in Crafter CMS v3.0.x via automation Nov 21, 2017

@dejan-brkic dejan-brkic added this to In Progress in Crafter CMS v2.5.x Nov 24, 2017

@dejan-brkic dejan-brkic moved this from Backlog to In Progress in Crafter CMS v3.0.x Nov 24, 2017

@dejan-brkic dejan-brkic moved this from In Progress to Test & Validate in Crafter CMS v3.0.x Nov 24, 2017

@dejan-brkic

This comment has been minimized.

Show comment
Hide comment
@dejan-brkic
Member

dejan-brkic commented Nov 24, 2017

3.0 Done
PR:
craftercms/studio#958

@dejan-brkic

This comment has been minimized.

Show comment
Hide comment
@dejan-brkic
Member

dejan-brkic commented Nov 24, 2017

2.5 Done
PR:
craftercms/studio#960

@dejan-brkic dejan-brkic moved this from In Progress to Testing in Crafter CMS v2.5.x Nov 24, 2017

@russdanner

This comment has been minimized.

Show comment
Hide comment
@russdanner

russdanner Dec 1, 2017

Member

2.5 TESTING: New, shared components were not published but should be
https://www.useloom.com/share/b5f37991d627483db2ee9cb71534c9ed

Member

russdanner commented Dec 1, 2017

2.5 TESTING: New, shared components were not published but should be
https://www.useloom.com/share/b5f37991d627483db2ee9cb71534c9ed

@dejan-brkic

This comment has been minimized.

Show comment
Hide comment
@dejan-brkic
Member

dejan-brkic commented Dec 1, 2017

Crafter CMS v3.0.x automation moved this from Test & Validate to Completed Jan 17, 2018

@sumerjabri sumerjabri moved this from Testing to Completed in Crafter CMS v2.5.x Aug 31, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment