New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use `AbstractTask.execute()` #1668

Closed
Vampire opened this Issue Dec 4, 2017 · 1 comment

Comments

@Vampire

Vampire commented Dec 4, 2017

I'm not using your project, I just stumbled upon it because of a Stackoverflow question.
I've seen you call AbstractTask.execute() in your build script multiple times.
This is a pretty big no-go.
AbstractTask.execute() is an internal method that is only callable because of the duck-typing of Groovy.
It must not be called, if you call this directly, you might execute tasks multiple times, there will no dependency tasks run before, up-to-date checks will not properly work and so on.
I strongly recommend you restructure your build to use proper Gradle way of doing things instead of calling internal methods that are not meant for direct calling.
If you don't want to, just close this issue, but I really strongly recommend you change this.

@cortiz

This comment has been minimized.

Show comment
Hide comment
@cortiz

cortiz Dec 15, 2017

Member

Removed all executed call and refactor most of the build to use dependencies and not execute

#1708

Member

cortiz commented Dec 15, 2017

Removed all executed call and refactor most of the build to use dependencies and not execute

#1708

@cortiz cortiz assigned sumerjabri and unassigned cortiz Dec 15, 2017

@cortiz cortiz moved this from Backlog to Test & Validate in Crafter CMS v3.0.x Dec 15, 2017

sumerjabri added a commit that referenced this issue Dec 18, 2017

@sumerjabri sumerjabri closed this Dec 18, 2017

Crafter CMS v3.0.x automation moved this from Test & Validate to Completed Dec 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment