New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[studio-ui] Content-type config.xml file does not let you save <delete-dependencies> #1673

Closed
alhambrav opened this Issue Dec 6, 2017 · 2 comments

Comments

@alhambrav
Member

alhambrav commented Dec 6, 2017

Expected behavior

Changes made in Content-type config.xml file should be saved when the Update button is pressed (Adding <delete-dependencies>) .

Actual behavior

Content-type config.xml file does not save changes made

Steps to reproduce the problem

  • Create a site using website_editorial or empty bp
  • Open the Sidebar and click on Site Config
  • Click on Content Types and then click on Open Existing Type
  • Select one of the content types, for the example below, the empty bp is used and the Entry content type was clicked.
  • Add the following to the Configuration "config.xml"
<delete-dependencies> 
    <delete-dependency> 
        <pattern>(^/static-assets/docs/.*)</pattern> 
        <remove-empty-folder>false</remove-empty-folder> 
    </delete-dependency> 
</delete-dependencies> 
  • Click on Update, then after it goes back to the content type dialog, click on Save
  • Now, go back to the Properties Explorer panel, Configuration property and click on the pencil icon next to config.xml again to view the file. Notice that the changes you saved earlier is gone.

Log/stack trace (use https://gist.github.com)

Here's a short clip:
https://www.useloom.com/share/50e1099548374ea3a5e01991ac14049d

Specs: version, OS, browser, etc.

OS X, Chrome browser
Studio Version Number: 3.0.2-a8afa1
Build Number: a8afa188dc381af4d744a267fc4278efa2e700a3
Build Date/Time: 12-06-2017 00:22:03 -0500

@sumerjabri sumerjabri added this to Backlog in Crafter CMS v3.0.x via automation Dec 11, 2017

@sumerjabri sumerjabri added this to the Crafter CMS v3.0.4 milestone Dec 11, 2017

@vestrada vestrada assigned vestrada and unassigned jvega190 Dec 12, 2017

@vestrada vestrada moved this from Backlog to In Progress in Crafter CMS v3.0.x Dec 12, 2017

vestrada added a commit to vestrada/studio-ui that referenced this issue Dec 14, 2017

craftercms/craftercms#1673 - [studio-ui] Content-type config.xml file…
… does not let you save <delete-dependencies> #1673

@vestrada vestrada referenced this issue Dec 14, 2017

Merged

#1673 #720

@vestrada

This comment has been minimized.

Show comment
Hide comment
@vestrada
Member

vestrada commented Dec 14, 2017

@vestrada vestrada moved this from In Progress to Test & Validate in Crafter CMS v3.0.x Dec 14, 2017

@vestrada vestrada assigned alhambrav and unassigned vestrada Dec 14, 2017

@alhambrav

This comment has been minimized.

Show comment
Hide comment
@alhambrav

alhambrav Dec 14, 2017

Member

Verified fixed.

Member

alhambrav commented Dec 14, 2017

Verified fixed.

@alhambrav alhambrav closed this Dec 14, 2017

Crafter CMS v3.0.x automation moved this from Test & Validate to Completed Dec 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment