New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[commons] StringToDateConverter shouldn't use a singleton SimpleDateFormat Instance #1743

Closed
avasquez614 opened this Issue Jan 4, 2018 · 3 comments

Comments

@avasquez614
Member

avasquez614 commented Jan 4, 2018

SimpleDateFormat is not thread safe so it could cause concurrency issues. Use an instance per call or use Apache Common's FastDateFormat.

@avasquez614 avasquez614 added this to the Crafter CMS v3.0.4 milestone Jan 4, 2018

@avasquez614 avasquez614 self-assigned this Jan 4, 2018

@avasquez614 avasquez614 added this to Backlog in Crafter CMS v3.0.x via automation Jan 4, 2018

@luis-rivet

This comment has been minimized.

Show comment
Hide comment
@luis-rivet

luis-rivet Jan 11, 2018

Contributor

Hi, guys, I want to know when this ticket will be resolved because I'm doing a load test and a good amount of them are failing because of it, with this solved I can deliver more accurate results
Thanks in advance

Contributor

luis-rivet commented Jan 11, 2018

Hi, guys, I want to know when this ticket will be resolved because I'm doing a load test and a good amount of them are failing because of it, with this solved I can deliver more accurate results
Thanks in advance

@avasquez614

This comment has been minimized.

Show comment
Hide comment
@avasquez614

avasquez614 Jan 15, 2018

Member

Hi @luis-rivet, the code is being pushed shortly

Member

avasquez614 commented Jan 15, 2018

Hi @luis-rivet, the code is being pushed shortly

@avasquez614

This comment has been minimized.

Show comment
Hide comment
@avasquez614
Member

avasquez614 commented Jan 15, 2018

Crafter CMS v3.0.x automation moved this from Backlog to Completed Jan 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment