New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

choice - scrolling modal or content pane only if overflow #286

Closed
noraheuer opened this Issue Jun 27, 2017 · 3 comments

Comments

Projects
None yet
3 participants
@noraheuer

noraheuer commented Jun 27, 2017

I understand why you changed the content overflow #13 back in 2015.
But at certain times I would like only the content pane to be scrollable, especially when action buttons are present and/or other form elements.
Is there any way we could make this a choice, how we want the content overflow handled?
In other words, scroll the full modal or only the the content pane?

@noraheuer noraheuer changed the title from overflow to choice - scrolling modal or content pane only if overflow Jun 27, 2017

@craftpip

This comment has been minimized.

Show comment
Hide comment
@craftpip

craftpip Jul 9, 2017

Owner

Hello @noraheuer thanks for your interest in the project,

The good news is that this is already been done in master branch, but not released,
The bad news is, its not optional to switch

The content will be scrolled inside the modal, and not the whole window.
This is because the modal is now centered using CSS tables, that results in much much smoother animations when centering the modal on the screen, and less mess, and I am not able to get CSS tables and full scroll to work together.

Owner

craftpip commented Jul 9, 2017

Hello @noraheuer thanks for your interest in the project,

The good news is that this is already been done in master branch, but not released,
The bad news is, its not optional to switch

The content will be scrolled inside the modal, and not the whole window.
This is because the modal is now centered using CSS tables, that results in much much smoother animations when centering the modal on the screen, and less mess, and I am not able to get CSS tables and full scroll to work together.

@noraheuer

This comment has been minimized.

Show comment
Hide comment
@noraheuer

noraheuer Jul 10, 2017

That is great news! I never liked the full scroll. Besides, if there is that much content to scroll, a modal is probably not the best way to access it, esp. on a small mobile screen.

noraheuer commented Jul 10, 2017

That is great news! I never liked the full scroll. Besides, if there is that much content to scroll, a modal is probably not the best way to access it, esp. on a small mobile screen.

@craftpip craftpip closed this Jan 20, 2018

@usb248

This comment has been minimized.

Show comment
Hide comment
@usb248

usb248 Apr 13, 2018

This is so ugly ... i don't understand this choice....two scrollbars 👎 💔

screenshot

usb248 commented Apr 13, 2018

This is so ugly ... i don't understand this choice....two scrollbars 👎 💔

screenshot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment