Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
[ Feature ] Support Assets encoded in Data URI #1189
Hey, thanks for the PR! I might not be able to get to looking over it until this weekend.
One thing to note is that using the
Looks good, merged! Thanks for the PR.
I made some non-functional tweaks (updating qunit in our package.json to match the version you'd manually updated to, upgrading our jshint rules to allow es6, and some minor formatting to whitespace.) Merge commit here.
I think I agree with this (and see #1106), at least with moving to ES6 where possible. I updated our linting rules to allow es6.
Each commit to develop pushes a build to the Crafty-Distro repository, so if you just need the
A full release (including pushing to npm, etc) generally happens when there's a useful enough set of changes to warrant it, and there aren't any additional breaking changes planned that would cause churn. In this case the fix includes breaking changes (using ES6 functionality), so I'd want to make some related changes before doing a full release.
If publishing to the npm is important, I can probably publish a beta/alpha build? Let me know if that's useful.