[ Feature ] Support Assets encoded in Data URI

[TechQuery]

• [ Add ] Support Assets encoded in Data URI
• [ Optimize ] Simplify core logic of the loader

Resolves #1188

[starwed]

Hey, thanks for the PR! I might not be able to get to looking over it until this weekend.

One thing to note is that using the Promise object would break compatibility with IE 9 - 11 completely which Crafty nominally supports. (But for many reasons, it might be time to just break that chain.)

[TechQuery]

@starwed
To import a Promise polyfill from CDN is so easy now, and it's good for making the code simpler & stronger.

At the same time, I also suggest to refactor this project with ECMAScript 6+ & Babel 7, it will make the core logic clearer.

[starwed]

Looks good, merged! Thanks for the PR.

I made some non-functional tweaks (updating qunit in our package.json to match the version you'd manually updated to, upgrading our jshint rules to allow es6, and some minor formatting to whitespace.) Merge commit here.

I also suggest to refactor this project with ECMAScript 6+ & Babel 7, it will make the core logic clearer.

I think I agree with this (and see #1106), at least with moving to ES6 where possible. I updated our linting rules to allow es6.

[TechQuery]

@starwed When is this feature published as a new version? A product of my company is based on it.

[starwed]

@starwed When is this feature published as a new version? A product of my company is based on it.

Each commit to develop pushes a build to the Crafty-Distro repository, so if you just need the crafty.js file that can work.

A full release (including pushing to npm, etc) generally happens when there's a useful enough set of changes to warrant it, and there aren't any additional breaking changes planned that would cause churn. In this case the fix includes breaking changes (using ES6 functionality), so I'd want to make some related changes before doing a full release.

If publishing to the npm is important, I can probably publish a beta/alpha build? Let me know if that's useful.