New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"exclude" should exclude a dependency transitively #52

Closed
dtanzer opened this Issue Jul 12, 2016 · 1 comment

Comments

Projects
None yet
2 participants
@dtanzer

dtanzer commented Jul 12, 2016

The following build script

plugins {
    id "com.craigburke.client-dependencies" version "1.1.4"
}

clientDependencies {
    installDir = 'src/main/resources/static/vendor'

    npm {
        'react' ('15.x.x')
        'react-dom' ('15.x.x')
        'babelify' ('7.3.0', exclude: 'babel-types')
        'babel-preset-react' ('6.x.x')
    }
}

Does not exclude "babel-types" from "babelify" - I guess because it is a transitive dependency. The script produces the following exception:

* What went wrong:
Execution failed for task ':web-frontend:clientReport'.
> com.craigburke.gradle.client.registry.core.CircularDependencyException: com.craigburke.gradle.client.registry.core.CircularDependencyException: com.craigburke.gradle.client.registry.core.CircularDependencyException: com.craigburke.gradle.client.registry.core.CircularDependencyException: Circular dependency created by dependency babel-types@^6.9.0

Excluding a dependency should also work when the library does not directly depend on the excluded dependency.

@craigburke craigburke self-assigned this Jul 12, 2016

@craigburke craigburke added this to the 1.2.0 milestone Sep 8, 2016

@craigburke

This comment has been minimized.

Show comment
Hide comment
@craigburke

craigburke Sep 12, 2016

Owner

Fixing the circular dependencies issue #51 seemed to resolve this one as well. I'll be release 1.2.0 shortly.

Owner

craigburke commented Sep 12, 2016

Fixing the circular dependencies issue #51 seemed to resolve this one as well. I'll be release 1.2.0 shortly.

@craigburke craigburke closed this Sep 12, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment