Refresh: Support django 3.1+ #59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you use QuerySet.defer() or QuerySet.only() to defer fields, and one of the fields you defer is the `type` field, this change means that typedmodels will no longer automatically cast the model instances in the queryset to the correct type. Previously, we did automatically cast the instances, at the expense of doing an extra query *per instance* (that's just how field deferral works.) With Django 3.2 (due to some complicated internal changes in the ORM) that no longer works.
craigds
force-pushed
the
modern-django
branch
6 times, most recently
from
d1b14d5 to
a4d8c5f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
todo:
test_generic_relationunder django 3.2 (?)