Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Can't test it without an audacity file, but here's a start. #1

Merged
merged 1 commit into from Mar 22, 2012

Conversation

Projects
None yet
2 participants
Contributor

mitechie commented Mar 22, 2012

  • Use the open context manager
  • Docstrings are good
  • make your functions generators and yield results so that it's not view +
    controller type functionality
  • Add a basic setup.py so you can python setup.py develop or better yet,
    python setup.py register && python setup.py sdist upload
  • Adds a command omcnotes once package is installed
  • Should add in some README, etc. but hey, I should be in bed.
Tweaks to the setup
- Use the open context manager
- Docstrings are good
- make your functions generators and yield results so that it's not view +
controller type functionality
- Add a basic setup.py so you can python setup.py develop or better yet,
    python setup.py register && python setup.py sdist upload
- Adds a command omcnotes once package is installed
- Should add in some README, etc. but hey, I should be in bed.

craigmaloney added a commit that referenced this pull request Mar 22, 2012

Merge pull request #1 from mitechie/master
Looks good. Will add an audacity file in a bit.

@craigmaloney craigmaloney merged commit ed5f308 into craigmaloney:master Mar 22, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment