Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FUJITSU: Improve handling of short (command only) messages. #1784

Merged
merged 3 commits into from
Apr 14, 2022

Commits on Mar 31, 2022

  1. IRFujitsuAC: add previous state support to toCommon()

    Try to better keep the settings if we can when using the `IRac` class interface, if supplied a previous state. This better handles the short commands that don't have most of the settings in them.
    
    Add unit tests to ensure it works as expected.
    
    For #1780
    crankyoldgit committed Mar 31, 2022
    Configuration menu
    Copy the full SHA
    c308888 View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2022

  1. IRFujitsuAc: Change toString() behaviour.

    * If we only have info from a _real_ short (command only) message, don't report other settings.
    
    This makes text for single messages more accurate.
    If the Class's state has been modified synthetically, report all the settings.
    
    For #1780
    crankyoldgit committed Apr 1, 2022
    Configuration menu
    Copy the full SHA
    2523d27 View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2022

  1. Code review feedback

    crankyoldgit committed Apr 2, 2022
    Configuration menu
    Copy the full SHA
    c080193 View commit details
    Browse the repository at this point in the history