Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bp: Fix PersistedClusterStateServiceTests.testSlowLogging #13061

Merged
merged 1 commit into from Sep 26, 2022

Conversation

mfussenegger
Copy link
Member

Summary of the changes / Why this improves CrateDB

elastic/elasticsearch@34fc52d

Failed with:

java.lang.AssertionError: max must be >= min: 1, 0
	at __randomizedtesting.SeedInfo.seed([A4C1A6C6699E9943:17EC0019C06CE531]:0)
	at com.carrotsearch.randomizedtesting.generators.RandomNumbers.randomLongBetween(RandomNumbers.java:29)
	at org.elasticsearch.test.ESTestCase.randomLongBetween(ESTestCase.java:506)
	at org.elasticsearch.gateway.PersistedClusterStateServiceTests.testSlowLogging(PersistedClusterStateServiceTests.java:840)

Checklist

  • Added an entry in CHANGES.txt for user facing changes
  • Updated documentation & sql_features table for user facing changes
  • Touched code is covered by tests
  • CLA is signed
  • This does not contain breaking changes, or if it does:
    • It is released within a major release
    • It is recorded in CHANGES.txt
    • It was marked as deprecated in an earlier release if possible
    • You've thought about the consequences and other components are adapted
      (E.g. AdminUI)

elastic/elasticsearch@34fc52d

Failed with:

    java.lang.AssertionError: max must be >= min: 1, 0
    	at __randomizedtesting.SeedInfo.seed([A4C1A6C6699E9943:17EC0019C06CE531]:0)
    	at com.carrotsearch.randomizedtesting.generators.RandomNumbers.randomLongBetween(RandomNumbers.java:29)
    	at org.elasticsearch.test.ESTestCase.randomLongBetween(ESTestCase.java:506)
    	at org.elasticsearch.gateway.PersistedClusterStateServiceTests.testSlowLogging(PersistedClusterStateServiceTests.java:840)
Copy link
Contributor

@matriv matriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx!

@mfussenegger mfussenegger merged commit d1a2960 into master Sep 26, 2022
@mfussenegger mfussenegger deleted the j/bp-fix branch September 26, 2022 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants