Skip to content

About query optimization and considerations for scaling#182

Closed
hlcianfagna wants to merge 100 commits intomainfrom
hlcianfagna/query_optimization
Closed

About query optimization and considerations for scaling#182
hlcianfagna wants to merge 100 commits intomainfrom
hlcianfagna/query_optimization

Conversation

@hlcianfagna
Copy link
Contributor

@hlcianfagna hlcianfagna commented Mar 4, 2025

About

Adding two new big sections about:

  • Query Optimization 101
  • Topics to watch out when productizing CrateDB

Preview

@hlcianfagna hlcianfagna changed the title Add optimization.rst Add new content on query optimization and typical limits Mar 4, 2025
Copy link
Member

@amotl amotl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a stack for submitting this patch. I didn't do a review, but I've outlined two spots to be able to link them into an upstream issue ticket on Pygments.

This should not block the patch from being merged.

Copy link
Member

@amotl amotl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Hernan. Thanks a stack for submitting this extensive page about CrateDB querying guidelines. While I've not reviewed the SQL statements, I've gone through the prose and added a few suggestions, just to use at your disposal.

Disclaimer: As I am not a native speaker, I might easily be wrong about many wording, syntactic, and punctuation details I've outlined. Please outright ignore or reject such suggestions.

hlcianfagna and others added 5 commits March 6, 2025 08:07
Co-authored-by: Andreas Motl <andreas.motl@crate.io>
Co-authored-by: Andreas Motl <andreas.motl@crate.io>
Co-authored-by: Andreas Motl <andreas.motl@crate.io>
Co-authored-by: Andreas Motl <andreas.motl@crate.io>
hlcianfagna and others added 15 commits March 10, 2025 16:34
Co-authored-by: Andreas Motl <andreas.motl@crate.io>
Co-authored-by: Andreas Motl <andreas.motl@crate.io>
Co-authored-by: Andreas Motl <andreas.motl@crate.io>
Co-authored-by: Andreas Motl <andreas.motl@crate.io>
Co-authored-by: Andreas Motl <andreas.motl@crate.io>
Co-authored-by: Andreas Motl <andreas.motl@crate.io>
Co-authored-by: Andreas Motl <andreas.motl@crate.io>
hlcianfagna and others added 24 commits April 8, 2025 13:55
Co-authored-by: Andreas Motl <andreas.motl@crate.io>
Co-authored-by: Andreas Motl <andreas.motl@crate.io>
Co-authored-by: Andreas Motl <andreas.motl@crate.io>
Co-authored-by: Andreas Motl <andreas.motl@crate.io>
Co-authored-by: Andreas Motl <andreas.motl@crate.io>
Co-authored-by: Andreas Motl <andreas.motl@crate.io>
Co-authored-by: Niklas Schmidtmer <hammerhead@users.noreply.github.com>
Co-authored-by: Niklas Schmidtmer <hammerhead@users.noreply.github.com>
Co-authored-by: Niklas Schmidtmer <hammerhead@users.noreply.github.com>
Co-authored-by: Kenneth Geisshirt <geisshirt@gmail.com>
Co-authored-by: Niklas Schmidtmer <hammerhead@users.noreply.github.com>
Applying some of Kneth's suggestions

Co-authored-by: Andreas Motl <andreas.motl@crate.io>
Co-authored-by: Kenneth Geisshirt <geisshirt@gmail.com>
I've added the details about tweaking overload protection and thread pools for frequent insert into select from.
Some other minor fixes applied as well.
@amotl
Copy link
Member

amotl commented Apr 8, 2025

Hi. @karynzv asked for support here, because CI is still failing. I will take over the branch, squash commits, and merge it when possible, if there are no other objections.

@amotl amotl force-pushed the hlcianfagna/query_optimization branch from c4d015f to d6b5b96 Compare April 8, 2025 19:17
@amotl
Copy link
Member

amotl commented Apr 8, 2025

Apparently I just destroyed the commit history 💥. 1 Apologies.
@karynzv: Can I humbly ask you to --force push from your workstation once again, without a previous git pull?

Footnotes

  1. Did not pull from the feature branch beforehand. 🙈

@amotl amotl force-pushed the hlcianfagna/query_optimization branch from d6b5b96 to c4d015f Compare April 8, 2025 19:24
@hlcianfagna
Copy link
Contributor Author

Superseded by #196

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants