About query optimization and considerations for scaling#182
Closed
hlcianfagna wants to merge 100 commits intomainfrom
Closed
About query optimization and considerations for scaling#182hlcianfagna wants to merge 100 commits intomainfrom
hlcianfagna wants to merge 100 commits intomainfrom
Conversation
amotl
reviewed
Mar 5, 2025
Member
There was a problem hiding this comment.
Hi Hernan. Thanks a stack for submitting this extensive page about CrateDB querying guidelines. While I've not reviewed the SQL statements, I've gone through the prose and added a few suggestions, just to use at your disposal.
Disclaimer: As I am not a native speaker, I might easily be wrong about many wording, syntactic, and punctuation details I've outlined. Please outright ignore or reject such suggestions.
Co-authored-by: Andreas Motl <andreas.motl@crate.io>
Co-authored-by: Andreas Motl <andreas.motl@crate.io>
Co-authored-by: Andreas Motl <andreas.motl@crate.io>
Co-authored-by: Andreas Motl <andreas.motl@crate.io>
amotl
reviewed
Mar 6, 2025
Co-authored-by: Andreas Motl <andreas.motl@crate.io>
Co-authored-by: Andreas Motl <andreas.motl@crate.io>
Co-authored-by: Andreas Motl <andreas.motl@crate.io>
Co-authored-by: Andreas Motl <andreas.motl@crate.io>
Co-authored-by: Andreas Motl <andreas.motl@crate.io>
Co-authored-by: Andreas Motl <andreas.motl@crate.io>
Co-authored-by: Andreas Motl <andreas.motl@crate.io>
Co-authored-by: Andreas Motl <andreas.motl@crate.io>
Co-authored-by: Andreas Motl <andreas.motl@crate.io>
…n in adf annotations
Co-authored-by: Andreas Motl <andreas.motl@crate.io>
Co-authored-by: Andreas Motl <andreas.motl@crate.io>
Co-authored-by: Andreas Motl <andreas.motl@crate.io>
Co-authored-by: Andreas Motl <andreas.motl@crate.io>
Co-authored-by: Niklas Schmidtmer <hammerhead@users.noreply.github.com>
Co-authored-by: Niklas Schmidtmer <hammerhead@users.noreply.github.com>
Co-authored-by: Niklas Schmidtmer <hammerhead@users.noreply.github.com>
Co-authored-by: Kenneth Geisshirt <geisshirt@gmail.com> Co-authored-by: Niklas Schmidtmer <hammerhead@users.noreply.github.com>
Applying some of Kneth's suggestions Co-authored-by: Andreas Motl <andreas.motl@crate.io> Co-authored-by: Kenneth Geisshirt <geisshirt@gmail.com>
I've added the details about tweaking overload protection and thread pools for frequent insert into select from. Some other minor fixes applied as well.
…rate/cratedb-guide into hlcianfagna/query_optimization
Member
|
Hi. @karynzv asked for support here, because CI is still failing. I will take over the branch, squash commits, and merge it when possible, if there are no other objections. |
c4d015f to
d6b5b96
Compare
Member
d6b5b96 to
c4d015f
Compare
Contributor
Author
|
Superseded by #196 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About
Adding two new big sections about:
Preview