New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Council god #387

Closed
wants to merge 106 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@PabloMansanet
Contributor

PabloMansanet commented Nov 1, 2016

The Ieoh Jian Council

Ieoh Jian Council, AKA the council god is now fully playable! This god is the result of a lot of community discussion and you can see the post here.

For an up-to-date description of the god mechanics see the feedback thread

@DracheReborn

This comment has been minimized.

DracheReborn commented on e16f018 Oct 10, 2016

In colour.cc it looks like there is leftover unintended comment (from defines.h)

This comment has been minimized.

Owner

PabloMansanet replied Oct 24, 2016

Thanks for the heads up!

@DracheReborn

This comment has been minimized.

DracheReborn commented on d23be47 Oct 10, 2016

Alternatively, just set all weapon/UC skills to the highest one. This seems cleaner and simpler, and there won't be weird issues of whether it is better to train all weapon skills equally.

This comment has been minimized.

Owner

PabloMansanet replied Oct 24, 2016

I see, but in that case you wouldn't respect the aptitude differences right?

With the current model, it really doesn't matter what you train unless you abandon the god. But when you're worshipping them, your skills are essentially dictated by your aptitudes. I like that an ogre won't be as skilled with blades as an elf, even if they get full cross training.

@DracheReborn

This comment has been minimized.

DracheReborn commented on 0358434 Oct 10, 2016

Possibly I am misunderstanding your intent here, but shouldn't the weapon collection be empty initially?

This comment has been minimized.

Owner

PabloMansanet replied Oct 24, 2016

You're right, all of these commits were quite exploratory :)

This mechanic is way simpler now, there is no collection vector. Instead, weapons are spawned and assigned a slot number which represents their age, and they get despawned based on that.

It's my first time with the codebase so I've been firing blindly for a while haha. In my last commits, I think I'm starting to have a mental map of where I want to take this. I appreciate you taking a look at it!

@PabloMansanet

This comment has been minimized.

Contributor

PabloMansanet commented Nov 25, 2016

Closing because there is another PR with a similar objective, being pointed at by Johnstein's experimental CBRO branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment