Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't re-check forgotten map squares (10461) #780

Merged
merged 1 commit into from Jul 23, 2018

Conversation

Projects
None yet
2 participants
@ebering
Copy link
Contributor

ebering commented Jun 8, 2018

Prevents annotations for runed doors and transporters from stacking up.


// But don't stop if we knew about it previously
if (env.map_forgotten.get()
&& !((*env.map_forgotten.get())(p).flags & MAP_SEEN_FLAG))

This comment has been minimized.

Copy link
@aidanholm

aidanholm Jun 8, 2018

Contributor

unique_ptr implements operator bool and operator*, so the .get() calls here should be superfluous

This comment has been minimized.

Copy link
@ebering

ebering Jun 8, 2018

Author Contributor

Thanks for the tip. There are superfluous get()s elsewhere in the crawl code.

Don't re-check forgotten map squares (10461)
Prevents annotations for runed doors and transporters from stacking up.

@ebering ebering force-pushed the ebering:bug-10461 branch from bffbd0e to e7add2d Jun 8, 2018

@ebering

This comment has been minimized.

Copy link
Contributor Author

ebering commented Jun 8, 2018

Force-pushed with the fixup commit squashed.

@aidanholm aidanholm merged commit b582571 into crawl:master Jul 23, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ebering ebering deleted the ebering:bug-10461 branch Jul 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.