Fixes/155 fix elements without interactions #272

Merged
merged 4 commits into from Jun 10, 2013

Projects

None yet

3 participants

@alexnederlof
Member

The problem was that the hashcode/equals function of Eventable.java wat incorrect. It didn't take the source and target vertexes into account.

It does now so Crawljax fill find many more vertexes.

This fixes #155

@avandeursen
Member

Double checked the hashcode/equals re-implementation you made, as I'm working on similar stuff myself for the Conditions hierarchy (see my testcase for Conditions) for issue #264.

For conditions, there is a class hierarchy, and different condition classes may have the same arguments.

To avoid that their hashcode is the same, I include the class name as well in the hashcode. See 4988994

Since Eventable is not subclassed, this is not necessary here at the moment it seems.

In short: Tricky business, but this seems OK, and there are test cases for both equality and hashcode.

@amesbah amesbah merged commit 89ee25a into master Jun 10, 2013
@amesbah amesbah deleted the fixes/155-fix-elements-without-interactions branch Jun 10, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment