New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes/155 fix elements without interactions #272

Merged
merged 4 commits into from Jun 10, 2013

Conversation

Projects
None yet
3 participants
@alexnederlof
Member

alexnederlof commented Jun 9, 2013

The problem was that the hashcode/equals function of Eventable.java wat incorrect. It didn't take the source and target vertexes into account.

It does now so Crawljax fill find many more vertexes.

This fixes #155

@avandeursen

This comment has been minimized.

Show comment
Hide comment
@avandeursen

avandeursen Jun 9, 2013

Member

Double checked the hashcode/equals re-implementation you made, as I'm working on similar stuff myself for the Conditions hierarchy (see my testcase for Conditions) for issue #264.

For conditions, there is a class hierarchy, and different condition classes may have the same arguments.

To avoid that their hashcode is the same, I include the class name as well in the hashcode. See 4988994

Since Eventable is not subclassed, this is not necessary here at the moment it seems.

In short: Tricky business, but this seems OK, and there are test cases for both equality and hashcode.

Member

avandeursen commented Jun 9, 2013

Double checked the hashcode/equals re-implementation you made, as I'm working on similar stuff myself for the Conditions hierarchy (see my testcase for Conditions) for issue #264.

For conditions, there is a class hierarchy, and different condition classes may have the same arguments.

To avoid that their hashcode is the same, I include the class name as well in the hashcode. See 4988994

Since Eventable is not subclassed, this is not necessary here at the moment it seems.

In short: Tricky business, but this seems OK, and there are test cases for both equality and hashcode.

amesbah added a commit that referenced this pull request Jun 10, 2013

Merge pull request #272 from crawljax/fixes/155-fix-elements-without-…
…interactions

Fixes/155 fix elements without interactions

@amesbah amesbah merged commit 89ee25a into master Jun 10, 2013

@amesbah amesbah deleted the fixes/155-fix-elements-without-interactions branch Jun 10, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment