New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes/241 candidate position out of place #273

Merged
merged 6 commits into from Jun 10, 2013

Conversation

Projects
None yet
2 participants
@alexnederlof
Member

alexnederlof commented Jun 9, 2013

I looks like the old problem of relative body layout was solved with the new version of selenium. This allows us to clean up a lot of the position calculation code.

Crawljax will now also log a warning if an element is inside an iFrame. We cannot show that in the Crawl overview because iFrames have a relative positioning system.

Closes #241

alexnederlof added some commits Jun 7, 2013

Working on #241. Problem of the positioning seems to be that Position…
….getY() returns a weird value.

- Also fixed big error prints when the crawler leaves the domain.
- The faulty `getY()` stuff is now printed too.

amesbah added a commit that referenced this pull request Jun 10, 2013

Merge pull request #273 from crawljax/fixes/241-candidate-position-ou…
…t-of-place

Fixes/241 candidate position out of place

@amesbah amesbah merged commit ffa9a92 into master Jun 10, 2013

@amesbah amesbah deleted the fixes/241-candidate-position-out-of-place branch Jun 10, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment