Switched to SLF4J #73

Merged
merged 4 commits into from Dec 17, 2012

Projects

None yet

2 participants

@alexnederlof
Member
  • Switched from Log4j to SLF4j
  • Updated the Assembly descripter to include the LICENSE and README
  • Updated the Assembly to include logback. The jar isn't included when packaging.
  • Let JUnit be a test dependency
@alexnederlof alexnederlof Switched to SLF4J
- Switched from Log4j to SLF4j
- Updated the Assembly descripter to include the LICENSE and README
- Updated the Assembly to include logback. The jar isn't included when packaging.
- Let JUnit be a test dependency
0e381f2
@alexnederlof
Member

Looking at the diff, it seems like not everything is formatted using the Crawljax formatter. I will look into this later.

@amesbah
Member
amesbah commented Dec 16, 2012

@alexnederlof Logging to the console is working fine. How do I get the logs into the "crawljax.log" file? Changing the level to INFO does not seem to have any effect!

@alexnederlof
Member

If you are running from a test, it uses src/test/resources/logback-test.xml to configure the log. That configuration doesn't have a file appender configured. If you are running it as a main method from src/main/java then you get the file appender configured in src/main/resources/logback.xml.

@amesbah
Member
amesbah commented Dec 17, 2012

But no matter what log level I set in src/main/resources/logback.xml no log file appears in my project workspace! Do you see the crawljax.log when you run one of the examples for instance?

@alexnederlof
Member

You're right! The scope for logback wasn't configured correctly. It is now.

@alexnederlof alexnederlof was assigned Dec 17, 2012
@amesbah
Member

Still not working; the log file is not created when I run CrawljaxAdvancedExampleSettings from Eclipse.

Member

Are you sure? It works fine for me. Did you refresh Eclipse?

Member

Refreshed Eclipse, changed level to debug/info. no sign of the log file so far.

Member

If you set <appender-ref ref="FILE" /> to <appender-ref ref="STDOUT" />, do you see anything in the console if you set both the logger entry and the root entry to level DEBUG?

@amesbah
Member
amesbah commented Dec 17, 2012

Works fine. It was a classpath issue caused by mvn eclipse:eclipse; switched to m2e and the problem is resolved.

@amesbah amesbah merged commit 08b2d85 into master Dec 17, 2012

1 check passed

default The Travis build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment