New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switched to SLF4J #73

Merged
merged 4 commits into from Dec 17, 2012

Conversation

Projects
None yet
2 participants
@alexnederlof
Member

alexnederlof commented Dec 16, 2012

  • Switched from Log4j to SLF4j
  • Updated the Assembly descripter to include the LICENSE and README
  • Updated the Assembly to include logback. The jar isn't included when packaging.
  • Let JUnit be a test dependency
Switched to SLF4J
- Switched from Log4j to SLF4j
- Updated the Assembly descripter to include the LICENSE and README
- Updated the Assembly to include logback. The jar isn't included when packaging.
- Let JUnit be a test dependency
@alexnederlof

This comment has been minimized.

Show comment
Hide comment
@alexnederlof

alexnederlof Dec 16, 2012

Member

Looking at the diff, it seems like not everything is formatted using the Crawljax formatter. I will look into this later.

Member

alexnederlof commented Dec 16, 2012

Looking at the diff, it seems like not everything is formatted using the Crawljax formatter. I will look into this later.

@amesbah

This comment has been minimized.

Show comment
Hide comment
@amesbah

amesbah Dec 16, 2012

Member

@alexnederlof Logging to the console is working fine. How do I get the logs into the "crawljax.log" file? Changing the level to INFO does not seem to have any effect!

Member

amesbah commented Dec 16, 2012

@alexnederlof Logging to the console is working fine. How do I get the logs into the "crawljax.log" file? Changing the level to INFO does not seem to have any effect!

@alexnederlof

This comment has been minimized.

Show comment
Hide comment
@alexnederlof

alexnederlof Dec 17, 2012

Member

If you are running from a test, it uses src/test/resources/logback-test.xml to configure the log. That configuration doesn't have a file appender configured. If you are running it as a main method from src/main/java then you get the file appender configured in src/main/resources/logback.xml.

Member

alexnederlof commented Dec 17, 2012

If you are running from a test, it uses src/test/resources/logback-test.xml to configure the log. That configuration doesn't have a file appender configured. If you are running it as a main method from src/main/java then you get the file appender configured in src/main/resources/logback.xml.

@amesbah

This comment has been minimized.

Show comment
Hide comment
@amesbah

amesbah Dec 17, 2012

Member

But no matter what log level I set in src/main/resources/logback.xml no log file appears in my project workspace! Do you see the crawljax.log when you run one of the examples for instance?

Member

amesbah commented Dec 17, 2012

But no matter what log level I set in src/main/resources/logback.xml no log file appears in my project workspace! Do you see the crawljax.log when you run one of the examples for instance?

@alexnederlof

This comment has been minimized.

Show comment
Hide comment
@alexnederlof

alexnederlof Dec 17, 2012

Member

You're right! The scope for logback wasn't configured correctly. It is now.

Member

alexnederlof commented Dec 17, 2012

You're right! The scope for logback wasn't configured correctly. It is now.

@ghost ghost assigned alexnederlof Dec 17, 2012

@amesbah

This comment has been minimized.

Show comment
Hide comment
@amesbah

amesbah Dec 17, 2012

Member

Still not working; the log file is not created when I run CrawljaxAdvancedExampleSettings from Eclipse.

Member

amesbah commented on 5eccbca Dec 17, 2012

Still not working; the log file is not created when I run CrawljaxAdvancedExampleSettings from Eclipse.

This comment has been minimized.

Show comment
Hide comment
@alexnederlof

alexnederlof Dec 17, 2012

Member

Are you sure? It works fine for me. Did you refresh Eclipse?

Member

alexnederlof replied Dec 17, 2012

Are you sure? It works fine for me. Did you refresh Eclipse?

This comment has been minimized.

Show comment
Hide comment
@amesbah

amesbah Dec 17, 2012

Member

Refreshed Eclipse, changed level to debug/info. no sign of the log file so far.

Member

amesbah replied Dec 17, 2012

Refreshed Eclipse, changed level to debug/info. no sign of the log file so far.

This comment has been minimized.

Show comment
Hide comment
@alexnederlof

alexnederlof Dec 17, 2012

Member

If you set <appender-ref ref="FILE" /> to <appender-ref ref="STDOUT" />, do you see anything in the console if you set both the logger entry and the root entry to level DEBUG?

Member

alexnederlof replied Dec 17, 2012

If you set <appender-ref ref="FILE" /> to <appender-ref ref="STDOUT" />, do you see anything in the console if you set both the logger entry and the root entry to level DEBUG?

@amesbah

This comment has been minimized.

Show comment
Hide comment
@amesbah

amesbah Dec 17, 2012

Member

Works fine. It was a classpath issue caused by mvn eclipse:eclipse; switched to m2e and the problem is resolved.

Member

amesbah commented Dec 17, 2012

Works fine. It was a classpath issue caused by mvn eclipse:eclipse; switched to m2e and the problem is resolved.

@amesbah amesbah merged commit 08b2d85 into master Dec 17, 2012

1 check passed

default The Travis build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment