-
-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FeatureRequest: Can diun if it has an update target container function use docker labels? #1
Comments
Hi @Leopere, Perhaps I misunderstood your request, but I would like to point out that unlike other tools like WatchTower, Diun is not intended to update containers but only to send notifications when an image is updated on a registry. On the other hand, I have planned in my TODO list to check images running via the Docker daemon. We could potentially use labels to filter those we want to analyze. |
The misunderstanding was mine I skimmed the documentation after seeing your
post on /r/docker and though I saw mentions of an update function. I love
the project thanks for the contribution to the internet.
…On Mon, Jun 10, 2019 at 8:43 AM CrazyMax ***@***.***> wrote:
Hi @Leopere <https://github.com/Leopere>,
Perhaps I misunderstood your request, but I would like to point out that
unlike other tools like WatchTower, Diun is not intended to update
containers but only to send notifications when an image is updated on a
registry.
On the other hand, I have planned in my TODO list
<https://github.com/crazy-max/diun#todo> to check images running via the
Docker daemon. We could potentially use labels to filter those we want to
analyze.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1?email_source=notifications&email_token=AAIE2VUAVYH6RFMCD5SRID3PZZEANA5CNFSM4HWQKATKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXJYUZI#issuecomment-500402789>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAIE2VUXRXSYHTLVOTOJZJTPZZEANANCNFSM4HWQKATA>
.
|
Closed in lieu of the creation of #3 |
This can probably be improved a lot (e.g. what to do with undefined environment variables, how to treat escaping of variables, adding conditional clauses, and so on), but by then it would probably be wise to just use a prebuilt config parser with environment support.
With a number of other things like Watchtower and Ouroboros you can establish container labels these labels can present triggers to other docker controlling and monitoring systems.
The thing I would love to see is for Diun to look for labels and just automatically detect the container's source and run checks against the upstream repository.
One such example is in the ouroboros documentation where the label determines to the Ouroboros appliance if the container should be handled by Ouroboros.
In this case, you could have a few labels I'm sure.
The text was updated successfully, but these errors were encountered: