New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Few changes #5
Few changes #5
Conversation
Oh and all the random spacing changes and stuff are from running |
Hi, first of all thanx for your PR. The style changes are fine for me, because it is the kind of style I also prefer, but it seems that I did not take care about it while coding I only had a quick look on your functions Moreover, due to changes in the functions a lot of tests now fail ( So, one could just include/export the functions |
Yeah, I should have mentioned I didn't write any tests or make sure that the existing tests were passing since I wasn't sure if you'd be game for the idea :) I totally get what you mean about leaving the I think the key thing is showing examples in the readme as "look at these nice dataframes you get with no effort" that are consistent (as much as possible) across functions. More attractive to people checking out the package than looking through the By the way -- have you tested
|
Hi, yep, it works for me, although the website says that the daily forecast is not included in the free plan :-) |
I added the option to store the api key in an environment variable called |
Ahh makes sense. Not super familiar with how you're doing the http mocking so I haven't yet been able to get a few of the tests to pass, but wanted to give you something to look at for I'll open a PR for this change. Let me know what you think about that and I'll look further into the mocking and write some tests for Re: the |
You are right, it does not make sense to remind users to store their api key in an environment variable in case they already do it. I will add your mechanism. Furthermore, I will take a look at your new pull request as soon as possible. At the moment time is a little bit limited. |
Awesome, no rush! |
Thanx again, I will close this one. Changes merged via #12. |
Hi and thanks for the awesome package!
You can take or leave some or all of this PR. Thought I'd send it over since it's made what I'm trying to do with the package a bit easier. Main things are:
parse_forecast
andparse_current
inlowlevel.R
that simplify the response and return similar-ish dataframes by default for easier comparisonWould love to hear your thoughts!