Remove allowBackup & supportsRtl from AndroidManifest

[christianchown]

RN 0.54 changes the AndroidManifest.xml setting for android:allowBackup from true to false: facebook/react-native@d7a9ca2

As react-native-splash-screen specifies android:allowBackup="true", this causes the following linker error for all new RN projects (and those that specify: android:allowBackup="false")

Attribute application@allowBackup value=(false) from AndroidManifest.xml
is also present at [react-native-splash-screen] AndroidManifest.xml value=(true).

Suggestion: add 'tools:replace="android:allowBackup"' to <application> 
element at AndroidManifest.xml

BUILD FAILED

This PR removes this default from the library, along with the default for android:supportsRtl, as per this suggestion: https://medium.com/@elye.project/2-lines-in-manifest-to-remove-when-sharing-your-android-library-565d4c4af04a

[lucidtheory]

Please merge this

[hoyajigi]

Please merge this

[WhatUsersLove]

Please merge... What is the work around for this right now?

[lucidtheory]

In development you can just edit the AndroidManifest.xml in the node_modules

If this isn't merged before you deploy you can fork the repo with the updates and use that as your source

[WhatUsersLove]

Great. So change android:allowBackup to true?

[lucidtheory]

Delete the line completely.

Also delete the line that says android:supportsRtl

Be sure you are removing it from the AndroidManifest.xml that is in the splash screen node_modules folder and not your main application one

[WhatUsersLove]

Now I get it. Thanks.

[WhatUsersLove]

So when am deploying for production I will fork the repo with the updates then how do I make it my source as I am reinstalling the library? (Im from a web dev background)

[lucidtheory]

that's ok,

in your package.json:

"dependenceis":{
      ...other packages
      "react-native-splash-screen": "github:yourGithubUserName/yourForkedRepoName"
}

so if you forked it under the same repo name it would be
"react-native-splash-screen": "github:TechyTimo/react-native-splash-screen"

[WhatUsersLove]

Excellent! Thanks

[christianchown]

@esdrasetrenne @TechyTimo

Cleaner workaround - keep package.json etc. as they were

AndroidManifest.xml

<application
      ...
      android:allowBackup="false"
      tools:replace="android:allowBackup"
>

[lucidtheory]

Oh nice, I have seen that before.

That would go in the main app's AndroidManifest.xml yea?

Also, I think with this xmlns:tools="http://schemas.android.com/tools" needs to be added to the manifest tag at the top if it is not already there

[christianchown]

@esdrasetrenne - yes, in your app's AndroidManifest.xml: and you're right about the tools schema too

[RWOverdijk]

Yes please. 👍

[tasarsu]

For the ones who had this error;

The prefix "tools" for attribute "tools:replace" associated with an element type "application" is not bound.

add xmlns:tools attributes to manifest tag

<manifest 
    xmlns:android="http://schemas.android.com/apk/res/android"
    xmlns:tools="http://schemas.android.com/tools"
    ...
>

[adlondon]

still crashing for me with all changes made through tasarsu's suggestion editing manfifest... no build errors, app just crashes on launch.

[dannevesdantas]

@adlondon make sure your color.xml exists in android/app/src/main/res/values

[adlondon]

colors.xml did it. Thanks all!