From 48c68315b96784b627a5836d5969137d1fd71cb1 Mon Sep 17 00:00:00 2001 From: Gerard Braad Date: Mon, 25 Nov 2019 11:52:13 +0000 Subject: [PATCH] Issue #838 Add virtualbox deprecation notice --- pkg/crc/machine/driver_darwin.go | 2 ++ pkg/crc/machine/driver_windows.go | 2 ++ pkg/crc/services/dns/dns_windows.go | 2 -- 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/pkg/crc/machine/driver_darwin.go b/pkg/crc/machine/driver_darwin.go index e6f1e52433..981d59440f 100644 --- a/pkg/crc/machine/driver_darwin.go +++ b/pkg/crc/machine/driver_darwin.go @@ -3,6 +3,7 @@ package machine import ( "github.com/code-ready/crc/pkg/crc/constants" "github.com/code-ready/crc/pkg/crc/errors" + "github.com/code-ready/crc/pkg/crc/logging" crcos "github.com/code-ready/crc/pkg/os" "github.com/code-ready/crc/pkg/crc/machine/config" @@ -39,6 +40,7 @@ func getDriverOptions(machineConfig config.MachineConfig) interface{} { switch machineConfig.VMDriver { case "virtualbox": + logging.Warn("Virtualbox support is deprecated and will be removed in the next release.") driver = virtualbox.CreateHost(machineConfig) case "hyperkit": driver = hyperkit.CreateHost(machineConfig) diff --git a/pkg/crc/machine/driver_windows.go b/pkg/crc/machine/driver_windows.go index f96583f220..029dcc5f9c 100644 --- a/pkg/crc/machine/driver_windows.go +++ b/pkg/crc/machine/driver_windows.go @@ -2,6 +2,7 @@ package machine import ( "github.com/code-ready/crc/pkg/crc/errors" + "github.com/code-ready/crc/pkg/crc/logging" crcos "github.com/code-ready/crc/pkg/os" "github.com/code-ready/crc/pkg/crc/machine/config" @@ -37,6 +38,7 @@ func getDriverOptions(machineConfig config.MachineConfig) interface{} { switch machineConfig.VMDriver { case "virtualbox": + logging.Warn("Virtualbox support is deprecated and will be removed in the next release.") driver = virtualbox.CreateHost(machineConfig) case "hyperv": driver = hyperv.CreateHost(machineConfig) diff --git a/pkg/crc/services/dns/dns_windows.go b/pkg/crc/services/dns/dns_windows.go index a148befd8b..cbed338072 100644 --- a/pkg/crc/services/dns/dns_windows.go +++ b/pkg/crc/services/dns/dns_windows.go @@ -7,7 +7,6 @@ import ( "time" "github.com/code-ready/crc/pkg/crc/errors" - "github.com/code-ready/crc/pkg/crc/output" "github.com/code-ready/crc/pkg/crc/services" winnet "github.com/code-ready/crc/pkg/os/windows/network" @@ -23,7 +22,6 @@ const ( func runPostStartForOS(serviceConfig services.ServicePostStartConfig, result *services.ServicePostStartResult) (services.ServicePostStartResult, error) { // bailout for Virtualbox if serviceConfig.DriverName == "virtualbox" { - output.Outln("Please follow instructions in the documentation about setting hostnames for Virtualbox.") result.Success = true return *result, nil }