Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coordinate testing #3

Closed
7 of 9 tasks
mpu-creare opened this issue Mar 13, 2018 · 6 comments
Closed
7 of 9 tasks

coordinate testing #3

mpu-creare opened this issue Mar 13, 2018 · 6 comments
Assignees
Labels
Milestone

Comments

@mpu-creare
Copy link
Contributor

@mpu-creare mpu-creare commented Mar 13, 2018

This involves migrating some old unit tests to pytests, writing some new unit tests, and removing some old unit tests.

  • util
  • base_coordinates
  • coordinates1d
  • array_coordinates1d
  • uniform_coordinates1d
  • stacked_coordinates
  • coordinates
  • cfunctions
  • group coordinates
@mpu-creare mpu-creare added this to To do in PODPAC Development Mar 13, 2018
@jmilloy jmilloy self-assigned this Apr 2, 2018
@jmilloy
Copy link
Collaborator

@jmilloy jmilloy commented Apr 2, 2018

@mpu-creare Are NaN values allowed in Coord or MonotonicCoord? I would assume definitely not in MonotonicCoord...?

@mpu-creare
Copy link
Contributor Author

@mpu-creare mpu-creare commented Apr 2, 2018

NaN's should not be allowed in coordinates... until we have a use-case that requires it.

I have had cases where my input sources put NaNs in their coordinates, but there I have to fix up their coordinates anyway... so perhaps we need tools to fill NaNs... but those already exist in xarray.

@jmilloy
Copy link
Collaborator

@jmilloy jmilloy commented Apr 2, 2018

@mpu can the padding for a coord select or intersect be negative?

@mpu-creare
Copy link
Contributor Author

@mpu-creare mpu-creare commented Apr 2, 2018

No.

@mpu-creare mpu-creare added this to the 0.2.0 milestone Aug 13, 2018
@mpu-creare mpu-creare added this to Ready in 0.2.0 Release Aug 13, 2018
@jmilloy
Copy link
Collaborator

@jmilloy jmilloy commented Sep 17, 2018

This issue should now be addressed again in earnest alongside #84.

@mpu-creare mpu-creare removed this from Ready in 0.2.0 Release Oct 8, 2018
@mpu-creare mpu-creare added this to To do in 0.2.1 Release Oct 8, 2018
@jmilloy jmilloy moved this from To do to In progress in 0.2.1 Release Nov 1, 2018
@mpu-creare mpu-creare removed this from In progress in 0.2.1 Release Nov 19, 2018
@mpu-creare mpu-creare added this to To do in 0.2.2 via automation Nov 19, 2018
@jmilloy jmilloy moved this from To do to In progress in 0.2.2 Nov 19, 2018
@jmilloy
Copy link
Collaborator

@jmilloy jmilloy commented Dec 6, 2018

I still need to test the intersect method in Coordinates, StackedCoordinates, and GroupCoordinates. But we've reached >90% for the coordinates, so I'm to close this. I'll need to add tests for select when I implement #118 so I will add intersect tests then, too.

@jmilloy jmilloy closed this Dec 6, 2018
0.2.2 automation moved this from In progress to Done Dec 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
0.2.2
  
Done
Development

No branches or pull requests

2 participants